-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Njit parallelization #16
Conversation
… njit_parallelization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Do we also want to make the pre-commit changes in this PR?
maybe if you can just run it once so it cleans things up, with |
Sounds good, I'll make the pre-commit changes and push. The output looks good, but doesn't 100% match the previous method (perhaps from a dtype), I'm investigating that before merging |
Fix the "type scheduled for deprecation" numba error, which was complaining about Q being a list of lists with different sizes (e.g. 1024, 512, 256, ...). I now populate an empty numpy array with the Q values to pass into - the loop only indexes the specific needed values, so it changes nothing (edit - this is lies, the output is now different, debugging...)