Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Njit parallelization #16

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Njit parallelization #16

merged 14 commits into from
Nov 9, 2023

Conversation

ramain
Copy link

@ramain ramain commented Nov 8, 2023

Fix the "type scheduled for deprecation" numba error, which was complaining about Q being a list of lists with different sizes (e.g. 1024, 512, 256, ...). I now populate an empty numpy array with the Q values to pass into - the loop only indexes the specific needed values, so it changes nothing (edit - this is lies, the output is now different, debugging...)

Copy link

@larskuenkel larskuenkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Do we also want to make the pre-commit changes in this PR?

@chrisfandrade16
Copy link

maybe if you can just run it once so it cleans things up, with pre-commit run --files cpu_fdmt.py, then re-stage and commit changes (or if you did pre-commit install on your cloned local repo at least once, and commit a file's changes with cz, it should run automatically)

@ramain
Copy link
Author

ramain commented Nov 9, 2023

Sounds good, I'll make the pre-commit changes and push. The output looks good, but doesn't 100% match the previous method (perhaps from a dtype), I'm investigating that before merging

@ramain ramain merged commit ee94df7 into main Nov 9, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants