HFB MPI fix hang on write-out #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To summarize what we learned last February (see comments in #237): running the HFB blind-search pipeline on multiple nodes hangs in a file write-out stage when the number of MPI processes is larger than the number of NS beams, possibly due to some upstream bug. This PR is a work-around to avoid the failure conditions. |
ljgray
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
This workaround looks fine. I think that this issue is probably the same as the one discussed in radiocosmology/caput#165, which had a lot of investigation but was never resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #237