Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent gpg from disrupting initial commit in addon change tracking repo #77

Merged

Conversation

ReveredRedHood
Copy link
Contributor

When git config --global --get commit.gpgsign is true (which GitHub documentation notes as an option when users want to sign all commits by default in any local repository on their computer), AddonsRepository.InstallAddonFromCache(...) fails when it attempts to run git commit -m Initial Commit.

This PR also changes the command from git commit -m Initial Commit to git commit -m "Initial Commit", but this was not the cause of the issue.

Discord message link describing issue: https://discord.com/channels/862108653488963604/1020542645677867128/1279413401159860226

@jolexxa jolexxa merged commit f27c8e9 into chickensoft-games:main Sep 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants