Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Windows on ARM support (#73) #74

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

stranne
Copy link
Contributor

@stranne stranne commented Aug 14, 2024

This update introduces support for Windows on ARM by using the ARM64 URL during installation.

Verification:

  • Verified on both Windows ARM64 and Windows x64 systems.
  • Added unit tests.

Note:

  1. No x64 Option for ARM64 Systems: The current version does not provide an option to install the x64 version on ARM64 systems.
  2. File Caching Issue: The file caching mechanism results in the same filename being used regardless of the processor architecture. This means that if a version has previously been downloaded, the same x64 download will be installed after this update on ARM64 systems, leading to an error during post-installation path validation.
  3. Compatibility with Pre-4.3 Versions: Attempting to install a version earlier than 4.3 will fail with the error: "Download failed. The remote server returned an error: (404) Not Found."
  4. List Command Limitation: The godot list command does not currently display which processor architecture a version refers to. This could obscure the fact that different versions were installed previously using x64 architecture. This limitation affects older installations only unless future changes allow for x64 versions to be installed on ARM64 systems as well.
  5. Uninstalling x64 versions: The current version does not account for scenarios where an installed version is x64 on ARM64 systems, which will likely require users to have to manually uninstall these versions if desired.

Feedback Request:

  • Should I address any of the issues listed above before this pull request is merged?
  • Are there any coding guidelines that I have missed?

I'm open to feedback.

Resolves #73

@jolexxa
Copy link
Member

jolexxa commented Aug 17, 2024

This has a conflict now that I merged #75 — did I merge these in the wrong order? 🤦‍♀️

@stranne
Copy link
Contributor Author

stranne commented Aug 17, 2024

No worries. I have resolved the merge conflicts, fixed the compilation errors that followed, and also tested the Godot's list, install, and uninstall commands after these changes on a Windows on ARM system.

@jolexxa jolexxa merged commit 5d04b28 into chickensoft-games:main Aug 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Windows on ARM Support
2 participants