Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site header/NavBar #13

Merged
merged 2 commits into from
May 3, 2024
Merged

Add Site header/NavBar #13

merged 2 commits into from
May 3, 2024

Conversation

imadrig
Copy link
Collaborator

@imadrig imadrig commented May 1, 2024

Description

DEV-32 - https://neptunedevs.atlassian.net/browse/DEV-32

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Testing Instructions

Please see Netlify Preview - a gray navigation bar with a logo placeholder should be visible on all pages.

Gotchas/What I learned

You can use Tailwind to apply a default height, and can set a break-point rule when the device screen reaches a certain size.

@github-actions github-actions bot requested review from exzo-14 and samwambam May 1, 2024 02:36
Copy link

netlify bot commented May 1, 2024

Deploy Preview for neptunenav ready!

Name Link
🔨 Latest commit cd6d3b6
🔍 Latest deploy log https://app.netlify.com/sites/neptunenav/deploys/6631aab34c0b3900087f0c4e
😎 Deploy Preview https://deploy-preview-13--neptunenav.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@samwambam samwambam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Nice tailwind additions

@imadrig imadrig merged commit 737c79a into main May 3, 2024
5 checks passed
@imadrig imadrig deleted the site-header branch May 3, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants