test(attributes): Add tests for missing href prop

Fixes #4239
cheeriojs · Dec 25, 2024 · 1b29bdb · 1b29bdb
1 parent 4d2d51d
commit 1b29bdb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/api/attributes.spec.ts b/src/api/attributes.spec.ts
@@ -321,6 +321,11 @@ describe('$(...)', () => {
       expect($(undefined).prop('href')).toBeUndefined();
     });
 
+    it('("href") : should skip values without an href', () => {
+      const $ = load('<a id="1">example1</a>');
+      expect($('#1').prop('href')).toBeUndefined();
+    });
+
     it('("src") : should resolve links with `baseURI`', () => {
       const $ = load(
         `
@@ -353,6 +358,13 @@ describe('$(...)', () => {
       expect($(undefined).prop('outerHTML')).toBeUndefined();
     });
 
+    it('("outerHTML") : should support root nodes', () => {
+      const $ = load('<div></div>');
+      expect($.root().prop('outerHTML')).toBe(
+        '<html><head></head><body><div></div></body></html>',
+      );
+    });
+
     it('("innerHTML") : should render properly', () => {
       const $a = $('<div><a></a></div>');
 

diff --git a/src/api/extract.spec.ts b/src/api/extract.spec.ts
@@ -118,4 +118,11 @@ describe('$.extract', () => {
       },
     });
   });
+
+  it('() : should not error on missing href prop (#4239)', () => {
+    const $ = load(fixtures.eleven);
+    expect<{ links: string[] }>(
+      $.extract({ links: [{ selector: 'li', value: 'href' }] }),
+    ).toStrictEqual({ links: [] });
+  });
 });