Easier unencrypted keys access. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanhesteren
changed the title
svanhesteren
force-pushed
the
easier-access-unencrypted-keys
branch
from
8be3338
to
de3eb54
Compare
skatkov
reviewed
Jul 12, 2024
| end | ||
| end | ||
|
|
||
| describe ".with_deep_deundescored_keys" do |
There was a problem hiding this comment.
thought: I'm wondering what would happen if we define _underscored_secret and underscored_secret in YAML?
There was a problem hiding this comment.
Previously it would raise
There was a problem hiding this comment.
It seems reasonable to raise? Why are we changing it? We are likely to replace one value with another - and if we forgot to remove encrypted or non-encrypted value - would be great to know about it.
Maybe at least log this?
There was a problem hiding this comment.
I removed it because else you can never have an encrypted and unencrypted key with the same name, which is something you could want. It's up to the user to decide what value they need.
and don't raise on duplicate key
skatkov
reviewed
Jul 15, 2024
julik
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a with_deep_deundescored_keys util method that iterates over all keys in a secrets hash and duplicates the underscored ones as de-underscored. This so we can more eassily access the unencrypted secrets without having to call it with an underscore in our rails application.