LP2053031: Adding tuning params #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @FrancescoDeSimone, I'm not sure if you saw the reply on Matrix, that's why I'll leave my comment here as well. Please refer here for further discussion. |
addyess
requested changes
Jan 16, 2025
snapshot_cout now accept a string that cloud be an integer number or auto
There was a problem hiding this comment.
Great work, thanks a lot @FrancescoDeSimone! Left some comments and suggestions.
Co-authored-by: Homayoon Alimohammadi <[email protected]>
Co-authored-by: Homayoon Alimohammadi <[email protected]>
Co-authored-by: Homayoon Alimohammadi <[email protected]>
addyess
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Only a tiny nit remains. Really nice work @FrancescoDeSimone
can you check out the unit test failures?
|
odd... the first run of the integration tests failed to complete I'll run again and see if it is successful |
|
@FrancescoDeSimone well I guess it wasn't a fluke. The integration tests are failing in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR add tuning parameters like heartbeat_interval, election_timeout, snapshot_count, as describe in LP:#2053031