Skip to content

Commit

Permalink
feat: Add og:image and og:title (#1078)
Browse files Browse the repository at this point in the history
Co-authored-by: tihuan <[email protected]>
  • Loading branch information
sethfeingold and tihuan authored Aug 23, 2024
1 parent 270653c commit 261ff81
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .infra/rdev/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ stack:
services:
explorer:
image:
tag: sha-de849f4b
tag: sha-06531c84
replicaCount: 1
env:
# env vars common to all deployment stages
Expand Down
2 changes: 2 additions & 0 deletions client/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>CELL&times;GENE | Explorer</title>
<meta property="og:title" content="CELLxGENE | Explorer" />
<meta property="og:image" content="static/images/cxg-explorer-og.jpg" />
<style>
html,
body,
Expand Down
33 changes: 0 additions & 33 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
"react-async": "^10.0.1",
"react-dom": "^17.0.2",
"react-flip-toolkit": "^7.0.12",
"react-helmet": "^6.1.0",
"react-icons": "^4.2.0",
"react-redux": "^7.2.0",
"redux": "^4.0.5",
Expand Down Expand Up @@ -150,7 +149,6 @@
"@types/pako": "^1.0.2",
"@types/react": "^17.0.14",
"@types/react-dom": "^17.0.9",
"@types/react-helmet": "^6.1.2",
"@types/react-redux": "^7.1.18",
"@types/sha1": "^1.1.3",
"@typescript-eslint/eslint-plugin": "^5.62.0",
Expand Down
Binary file added client/src/assets/img/cxg-explorer-og.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 0 additions & 2 deletions client/src/components/app.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React from "react";
import Helmet from "react-helmet";
import { connect } from "react-redux";
import { ThemeProvider as EmotionThemeProvider } from "@emotion/react";
import { StyledEngineProvider, ThemeProvider } from "@mui/material/styles";
Expand Down Expand Up @@ -81,7 +80,6 @@ class App extends React.Component<StateProps & { dispatch: AppDispatch }> {
<StyledEngineProvider injectFirst>
<EmotionThemeProvider theme={theme}>
<ThemeProvider theme={theme}>
<Helmet title="CELL&times;GENE | Explorer" />
{loading ? <LayoutSkeleton /> : null}
{error ? (
<div
Expand Down
7 changes: 7 additions & 0 deletions client/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ import "./assets/img/chrome.png";
import "./assets/img/firefox.png";
import "./assets/img/edge.png";
import "./assets/img/cellxgene.png";

/**
* These are imported for Webpack asset/resource module
* to bundle in order to be used in open graph meta tags
*/
import "./assets/img/cxg-explorer-og.jpg";

import { checkFeatureFlags } from "./util/featureFlags/featureFlags";

FocusStyleManager.onlyShowFocusOnTabs();
Expand Down

0 comments on commit 261ff81

Please sign in to comment.