Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NavigationFooter): implement NavigationFooter component #886

Open
wants to merge 3 commits into
base: jeremy/mobile-font-styles
Choose a base branch
from

Conversation

codemonkey800
Copy link
Contributor

Summary

Github issue: #817

Implements NavigationFooter component for desktop and mobile

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@kev-zunshiwang
Copy link

kev-zunshiwang commented Oct 30, 2024

Thanks Jeremy! Most feedback are similar to the header feedback, except the image slot one is new.

Desktop Feedback
Logo Slot

  • Update color to Base/border for the dash border line around "logo slot"
  • Unbold the text "logo slot"
  • The entire area of "logo slot / logo name / beta tag" should be linked to the home page of the product. Not sure if this affects the code

Tag

  • Update text inside the tags to title case
  • Remove the hover effect for the tags

Image slot

  • each image should have a link to the designated home page of that logo
  • Update the "person" minimal button to a icon button (see design for the specific spec)

@kev-zunshiwang
Copy link

Mobile Feedback
Logo

  • whole area should be a link
    Nav item
  • On hover, bold the text with Narrow/fontBodyS/600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants