Support alternative S3 endpoints #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlin
reviewed
Sep 5, 2022
| inputs: Dict[str, Any] = { | ||
| "uri": uri, | ||
| "docker": cfg["download_awscli"]["docker"], | ||
| "endpoint": cfg["download_awscli"].get("endpoint"), |
There was a problem hiding this comment.
This get() throws unless either we provide a non-None default (second argument), or keep endpoint defined (not commented out) in the default.cfg. The default.cfg could just have endpoint= to define it to an empty string (but then that has to be detected in the tasks WDL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #597. It adds an optional configuration parameter (
endpoint) to thedownload_awsclisection. Ifendpointis specified, then it is passed as the value of the--endpoint-urloption tos3when performingcpoperations.