fix(Link): handle inverse variant for standalone links #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2042 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 109 109
Lines 2613 2615 +2
Branches 664 665 +1
=======================================
+ Hits 2546 2548 +2
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Fix here is to make cases where we have standalone links with default variant appear with the correct color |
ahuth
approved these changes
Aug 23, 2024
| @@ -26,7 +26,7 @@ type Story = StoryObj<typeof Link>; | |||
| export const Default: Story = {}; | |||
|
|
|||
| /** | |||
| * When using context, you can specify a trailing icon for the link. | |||
| * When using standalone context, you can specify a trailing icon for the link. | |||
There was a problem hiding this comment.
What's standalone context, and/or can we clarify that?
Although I'm only looking at the diff, not the storybook. Might be more clear
There was a problem hiding this comment.
@ahuth yah, we include this in storybook
Glad you mention this b/c in this PR i also want to mention color behavior here, and make a small formatting tweak for consistency.
- update documentation to explain cases - add warning for misaligned prop usages - update snapshots and tests
booc0mtaco
force-pushed
the
aholloway/EDS-1398
branch
from
c0566f5
to
c110454
Compare
Merged
booc0mtaco
added a commit
that referenced
this pull request
Aug 23, 2024
## [15.3.0](v15.2.1...v15.3.0) (2024-08-23) [Storybook](https://61313967cde49b003ae2a860-vuzmfnjuoj.chromatic.com/) Figma Components Library: 🟢 No breaking changes - EDS-toastNotification: - deleted the dissmissType property - Added Toast Pattern documentation to handle multiple toasts - EDS-popover: added EDS-popover 2.0 component ### Features * **config:** add transition durations for tailwind ([#2036](#2036)) ([aed0f09](aed0f09)) * **Popover:** update theming to 2.0 ([#2031](#2031)) ([c5ab351](c5ab351)) * **tokens:** add in additional table tokens ([#2035](#2035)) ([a698a5b](a698a5b)) * **tokens:** update visited tokens ([#2034](#2034)) ([df84c87](df84c87)) ### Bug Fixes * **Card:** add spacing between eyebrow and title ([#2040](#2040)) ([d6ee15d](d6ee15d)) * **Link:** handle inverse variant for standalone links ([#2042](#2042)) ([351d7fd](351d7fd)) * **Popover:** update component version number ([#2038](#2038)) ([9940d76](9940d76))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: