Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Link): handle inverse variant for standalone links #2042

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

booc0mtaco
Copy link
Contributor

  • update documentation to explain cases
  • add warning for misaligned prop usages
  • update snapshots and tests

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team August 23, 2024 18:02
Copy link

github-actions bot commented Aug 23, 2024

size-limit report 📦

Path Size
components 89.26 KB (+0.09% 🔺)
styles 27.27 KB (+0.06% 🔺)

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (d6ee15d) to head (c110454).
Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2042   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         109      109           
  Lines        2613     2615    +2     
  Branches      664      665    +1     
=======================================
+ Hits         2546     2548    +2     
  Misses         65       65           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco
Copy link
Contributor Author

Fix here is to make cases where we have standalone links with default variant appear with the correct color

https://61313967cde49b003ae2a860-xiicuaigmu.chromatic.com/?path=/story/components-link--standalone-inverse-variant

@@ -26,7 +26,7 @@ type Story = StoryObj<typeof Link>;
export const Default: Story = {};

/**
* When using context, you can specify a trailing icon for the link.
* When using standalone context, you can specify a trailing icon for the link.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's standalone context, and/or can we clarify that?

Although I'm only looking at the diff, not the storybook. Might be more clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuth yah, we include this in storybook
Screenshot 2024-08-23 at 15 16 33

Glad you mention this b/c in this PR i also want to mention color behavior here, and make a small formatting tweak for consistency.

- update documentation to explain cases
- add warning for misaligned prop usages
- update snapshots and tests
@booc0mtaco booc0mtaco merged commit 351d7fd into next Aug 23, 2024
9 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1398 branch August 23, 2024 20:31
@booc0mtaco booc0mtaco mentioned this pull request Aug 23, 2024
booc0mtaco added a commit that referenced this pull request Aug 23, 2024
## [15.3.0](v15.2.1...v15.3.0) (2024-08-23)

[Storybook](https://61313967cde49b003ae2a860-vuzmfnjuoj.chromatic.com/)

Figma Components Library:
🟢  No breaking changes
- EDS-toastNotification:
  - deleted the dissmissType property
  - Added Toast Pattern documentation to handle multiple toasts
- EDS-popover: added EDS-popover 2.0 component

### Features

* **config:** add transition durations for tailwind ([#2036](#2036)) ([aed0f09](aed0f09))
* **Popover:** update theming to 2.0 ([#2031](#2031)) ([c5ab351](c5ab351))
* **tokens:** add in additional table tokens ([#2035](#2035)) ([a698a5b](a698a5b))
* **tokens:** update visited tokens ([#2034](#2034)) ([df84c87](df84c87))


### Bug Fixes

* **Card:** add spacing between eyebrow and title ([#2040](#2040)) ([d6ee15d](d6ee15d))
* **Link:** handle inverse variant for standalone links ([#2042](#2042)) ([351d7fd](351d7fd))
* **Popover:** update component version number ([#2038](#2038)) ([9940d76](9940d76))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants