-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add transition durations for tailwind #2036
Conversation
Screen.Recording.2024-08-15.at.10.19.21.mov |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2036 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 109 109
Lines 2613 2613
Branches 664 664
=======================================
Hits 2546 2546
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
2f62f06
to
fe915ba
Compare
@ahuth Fun little puzzle you might have a nice idea for. So in this example, what I want to do is use a list to store records for the notifications that get added.
Maybe i talked myself into a solution, but wanted to loop you in anyway lol |
Ah nice, I like the debounce idea. Only cleanup when toast stuff isn't happening? On the other hand, if it's just for stories, maybe it's fine to let the list get super large? |
Yah, we have control over the time period for how long it takes to transition out, so could keep them in sync. I like the idea of keeping the example simple and describing it as demo-only (e.g., "in a production implementation, make sure to prune the notification list once dismissal has occurred") |
- demo autodismiss behavior with stack of notifications - use state to track
- add in durations via (transitionDuration) - add in new toast notification implementation example - use new medium durations in example - demo autodismiss behavior with stack of notifications - use state to track # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Thu Aug 15 10:40:43 2024 -0400 # # On branch aholloway/EDS-1385 # Changes to be committed: # deleted: src/components/ToastNotification/ToastNotification.stories.ts # new file: src/components/ToastNotification/ToastNotification.stories.tsx # modified: tailwind.config.ts #
fe915ba
to
2e7de53
Compare
## [15.3.0](v15.2.1...v15.3.0) (2024-08-23) [Storybook](https://61313967cde49b003ae2a860-vuzmfnjuoj.chromatic.com/) Figma Components Library: 🟢 No breaking changes - EDS-toastNotification: - deleted the dissmissType property - Added Toast Pattern documentation to handle multiple toasts - EDS-popover: added EDS-popover 2.0 component ### Features * **config:** add transition durations for tailwind ([#2036](#2036)) ([aed0f09](aed0f09)) * **Popover:** update theming to 2.0 ([#2031](#2031)) ([c5ab351](c5ab351)) * **tokens:** add in additional table tokens ([#2035](#2035)) ([a698a5b](a698a5b)) * **tokens:** update visited tokens ([#2034](#2034)) ([df84c87](df84c87)) ### Bug Fixes * **Card:** add spacing between eyebrow and title ([#2040](#2040)) ([d6ee15d](d6ee15d)) * **Link:** handle inverse variant for standalone links ([#2042](#2042)) ([351d7fd](351d7fd)) * **Popover:** update component version number ([#2038](#2038)) ([9940d76](9940d76))
add in durations via (transitionDuration)
add in new toast notification implementation example
use new medium durations in example
demo autodismiss behavior with stack of notifications
use state to track
Test Plan: