Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): specify a font size for the checked glyph #2030

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

booc0mtaco
Copy link
Contributor

Specify a font-size for the glyph in the checkbox so that wrapping adjacent text doesn't change the size of the glyph when :checked

Test Plan:

Before:
Screenshot 2024-08-08 at 17 16 24

After:
Screenshot 2024-08-08 at 17 16 29

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team August 8, 2024 22:24
Copy link

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
components 89.26 KB (0%)
styles 27.68 KB (+0.13% 🔺)

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (2ad7b4c) to head (4c93c92).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2030   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         109      109           
  Lines        2608     2608           
  Branches      664      664           
=======================================
  Hits         2541     2541           
  Misses         65       65           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- add story to test layout
- update snapshots
@booc0mtaco booc0mtaco merged commit 6777316 into next Aug 9, 2024
9 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1393 branch August 9, 2024 14:55
@booc0mtaco booc0mtaco mentioned this pull request Aug 9, 2024
booc0mtaco added a commit that referenced this pull request Aug 12, 2024
### [15.2.1](v15.2.0...v15.2.1) (2024-08-09)

[Storybook](https://61313967cde49b003ae2a860-wzpwvsymfs.chromatic.com/)

### Bug Fixes

* **Button:** update button padding to match design ([#2027](#2027)) ([15644d3](15644d3))
* **Checkbox:** specify a font size for the checked glyph ([#2030](#2030)) ([6777316](6777316))
* **Menu:** remove style overrides to Menu.Button ([#2029](#2029)) ([2ad7b4c](2ad7b4c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants