Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InputField): align text content with inputWithin spacing #2020

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(InputField): align text content with inputWithin spacing #2020

merged 1 commit into from
Jul 19, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Jul 18, 2024 •
edited
Loading

  • specify max width to 96px
  • add story and update snapshots
Screenshot 2024-07-19 at 10 36 20

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
components 88.78 KB (0%)
styles 27.78 KB (+0.14% 🔺)

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (3b94114) to head (d033e78).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2020   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         109      109           
  Lines        2579     2579           
  Branches      647      647           
=======================================
  Hits         2512     2512           
  Misses         65       65           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco marked this pull request as draft July 18, 2024 00:20
@booc0mtaco booc0mtaco marked this pull request as ready for review July 19, 2024 15:35
@booc0mtaco
fix(InputField): align text content with inputWithin spacing
d033e78 
- specify max width to 96px
- add story and update snapshots
@booc0mtaco booc0mtaco requested a review from a team July 19, 2024 15:48
@booc0mtaco
Copy link
Contributor Author

@ahuth dope, thanks

@booc0mtaco booc0mtaco merged commit e87767b into next Jul 19, 2024
10 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1379 branch July 19, 2024 16:39
@booc0mtaco booc0mtaco mentioned this pull request Jul 25, 2024
Merged
booc0mtaco added a commit that referenced this pull request Jul 26, 2024
@booc0mtaco
Merge pull request #2024 from chanzuckerberg/release-v15.2.0
1b1ea55 
## [15.2.0](v15.1.0...v15.2.0) (2024-07-25)

[Storybook](https://61313967cde49b003ae2a860-bksjqddurj.chromatic.com/)

### Features

* **Fieldset:** update styles to support new 2.0 components ([#2023](#2023)) ([e542b32](e542b32))


### Bug Fixes

* **Button:** update typography tokens to match design ([#2019](#2019)) ([3b94114](3b94114))
* **InputField:** align text content with inputWithin spacing ([#2020](#2020)) ([e87767b](e87767b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuth ahuth ahuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @ahuth