-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] CensusSCVIDataModule + notebook #1196
base: main
Are you sure you want to change the base?
Conversation
…ml/pytorch.py Co-authored-by: Andrew Tolopko <[email protected]>
api/python/cellxgene_census/src/cellxgene_census/experimental/ml/datamodule.py
Outdated
Show resolved
Hide resolved
api/python/cellxgene_census/src/cellxgene_census/experimental/ml/datamodule.py
Outdated
Show resolved
Hide resolved
@ebezzi Should we add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the notebook. @ebezzi do you have any hints as to why?
https://github.com/chanzuckerberg/cellxgene-census/pull/1196/files#r1660286829
} | ||
], | ||
"source": [ | ||
"import cellxgene_census\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move all imports here?
@ebezzi can you please add two cells at the end:
and
|
Co-authored-by: pablo-gar <[email protected]>
Co-authored-by: pablo-gar <[email protected]>
Co-authored-by: pablo-gar <[email protected]>
It's already in the requirements (see pyproject.toml) |
Co-authored-by: pablo-gar <[email protected]>
Co-authored-by: pablo-gar <[email protected]>
Co-authored-by: pablo-gar <[email protected]>
…berg/cell-census into ebezzi/census-scvi-datamodule
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
+ Coverage 91.11% 91.16% +0.04%
==========================================
Files 77 77
Lines 5923 6022 +99
==========================================
+ Hits 5397 5490 +93
- Misses 526 532 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed. |
Comment to keep PR open |
This PR contains:
Note for reviewers: marking as draft as there are some items missing:
CensusSCVIDataModule
needs to be refactored to comply with our linter