Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] CensusSCVIDataModule + notebook #1196

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jun 17, 2024

This PR contains:

  1. An implementation of CensusSCVIDataModel that allows to train an scVI model using the Pytorch data loaders
  2. A notebook that explains how to do the training end to end. Preview here

Note for reviewers: marking as draft as there are some items missing:

  1. Still depends on [python] Support custom obs encoders #1191, which in turns require some testing/changes. Currently WIP
  2. CensusSCVIDataModule needs to be refactored to comply with our linter

@ebezzi ebezzi changed the base branch from main to ebezzi/support-custom-obs-encoders June 17, 2024 22:44
@pablo-gar
Copy link
Contributor

pablo-gar commented Jun 30, 2024

@ebezzi Should we add torchdata as a dependency of the experimental package? it's required by CensusSCVIDataModule

Copy link
Contributor

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the notebook. @ebezzi do you have any hints as to why?

https://github.com/chanzuckerberg/cellxgene-census/pull/1196/files#r1660286829

}
],
"source": [
"import cellxgene_census\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move all imports here?

@pablo-gar
Copy link
Contributor

@ebezzi can you please add two cells at the end:

sc.pl.umap(adata, color="tissue_general", title="SCVI")

and

sc.pl.umap(adata, color="cell_type", title="SCVI")

@ebezzi
Copy link
Member Author

ebezzi commented Jul 1, 2024

@ebezzi Should we add torchdata as a dependency of the experimental package? it's required by CensusSCVIDataModule

It's already in the requirements (see pyproject.toml)

@ebezzi ebezzi marked this pull request as ready for review July 1, 2024 22:04
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.16%. Comparing base (8d1e103) to head (6edd123).
Report is 30 commits behind head on main.

Files Patch % Lines
...us/src/cellxgene_census/experimental/ml/pytorch.py 90.62% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   91.11%   91.16%   +0.04%     
==========================================
  Files          77       77              
  Lines        5923     6022      +99     
==========================================
+ Hits         5397     5490      +93     
- Misses        526      532       +6     
Flag Coverage Δ
unittests 91.16% <92.59%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from ebezzi/support-custom-obs-encoders to main July 6, 2024 01:38
Copy link

github-actions bot commented Aug 3, 2024

This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Aug 3, 2024
@pablo-gar
Copy link
Contributor

Comment to keep PR open

@github-actions github-actions bot removed the Stale label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants