Language: Use parent ISO code + self ID for new sub languages #6016
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| if ($sub_language_id_exist) { | ||
| $language_name = SubLanguageManager::get_name_of_language_by_id($_GET['sub_language_id']); | ||
| $sub_language_id = $request->query->getInt('sub_language_id'); | ||
| if (!SubLanguageManager::languageExistsById($parent_id)) { |
There was a problem hiding this comment.
Variable "parent_id" is not in valid camel caps format
| $language_name = $language_details['original_name']; | ||
| $parent_id = $request->query->getInt('id'); | ||
| } | ||
| $language_details = SubLanguageManager::get_all_information_of_language($parent_id); |
There was a problem hiding this comment.
Variable "language_details" is not in valid camel caps format
| $language_name = $language_details['original_name']; | ||
| $parent_id = $request->query->getInt('id'); | ||
| } | ||
| $language_details = SubLanguageManager::get_all_information_of_language($parent_id); |
There was a problem hiding this comment.
Variable "parent_id" is not in valid camel caps format
| 'sub_language_add.php?id='.Security::remove_XSS($_GET['id']).'&action=definenewsublanguage' | ||
| ); | ||
| $form->addHeader( | ||
| get_lang('Create sub-languageForLanguage').' ( '.strtolower($language_name).' )' |
There was a problem hiding this comment.
Variable "language_name" is not in valid camel caps format
| $original_name = $request->request->get('original_name'); | ||
| $english_name = str_replace(' ', '_', $request->request->get('english_name')); | ||
| $isocode = str_replace(' ', '_', $request->request->get('isocode')); | ||
| $check_information = SubLanguageManager::checkIfLanguageExists( |
There was a problem hiding this comment.
Variable "check_information" is not in valid camel caps format
…guages - refs BT#21568
| ); | ||
| } | ||
| if (strlen($values['original_name']) > 0 && strlen($values['english_name']) > 0 && strlen($values['isocode']) > 0) { | ||
| if ($allow_insert_info) { |
There was a problem hiding this comment.
Variable "allow_insert_info" is not in valid camel caps format
| $values['english_name'], | ||
| $values['sub_language_is_visible'] ?? false, | ||
| $parent_id, | ||
| $language_details['isocode'] |
There was a problem hiding this comment.
Variable "language_details" is not in valid camel caps format
| .$values['english_name'].'<br/>'.get_lang('Character set').' : '.$newSubLanguage->getIsocode(); | ||
|
|
||
| Display::addFlash( | ||
| Display::return_message(get_lang('The new sub-language has been added').$str_info, 'normal', false) |
There was a problem hiding this comment.
Variable "str_info" is not in valid camel caps format
| $content .= $form->returnForm(); | ||
| } | ||
| if ('definenewsublanguage' == $requestAction) { | ||
| } elseif (true === SubLanguageManager::isParentOfSubLanguage($parent_id) |
There was a problem hiding this comment.
Variable "parent_id" is not in valid camel caps format
| ) { | ||
| $sub_language_id = $request->query->getInt('sub_language_id'); | ||
|
|
||
| if (!SubLanguageManager::languageExistsById($sub_language_id)) { |
There was a problem hiding this comment.
Variable "sub_language_id" is not in valid camel caps format
|
Code Climate has analyzed commit 3e39091 and detected 37 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
refs BTT#21568