-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Add token validation system initial implementation - refs #5959 #5963
Conversation
@@ -0,0 +1,119 @@ | |||
<?php | |||
|
|||
declare(strict_types=1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a single space around assignment operators
use Symfony\Component\Routing\Annotation\Route; | ||
use Symfony\Component\Security\Core\Security; | ||
|
||
#[Route('/validate')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
use Symfony\Component\Security\Core\Security; | ||
|
||
#[Route('/validate')] | ||
class ValidationTokenController extends AbstractController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must use "/**" style comments for a class comment
#[Route('/validate')] | ||
class ValidationTokenController extends AbstractController | ||
{ | ||
public function __construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing function doc comment
class ValidationTokenController extends AbstractController | ||
{ | ||
public function __construct( | ||
private readonly ValidationTokenHelper $validationTokenHelper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line indented incorrectly; expected 4 spaces, found 8
Code Climate has analyzed commit b915da8 and detected 74 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.