Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Add token validation system initial implementation - refs #5959 #5963

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

@@ -0,0 +1,119 @@
<?php

declare(strict_types=1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators

use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Security;

#[Route('/validate')]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

use Symfony\Component\Security\Core\Security;

#[Route('/validate')]
class ValidationTokenController extends AbstractController
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use "/**" style comments for a class comment

#[Route('/validate')]
class ValidationTokenController extends AbstractController
{
public function __construct(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

class ValidationTokenController extends AbstractController
{
public function __construct(
private readonly ValidationTokenHelper $validationTokenHelper,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line indented incorrectly; expected 4 spaces, found 8

Copy link

codeclimate bot commented Dec 12, 2024

Code Climate has analyzed commit b915da8 and detected 74 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 67
Clarity 6
Bug Risk 1

View more on Code Climate.

@christianbeeznest christianbeeznest merged commit e717c78 into chamilo:master Dec 18, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant