-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single target testing #6556
Single target testing #6556
Conversation
Enable building and testing via a single target (check) - require chakracore library to be built before the test run.
The idea is that we can invoke one target, which would be |
Manipulate build target: run tests for debug builds and simply build for release.
Expand CI matrix to include OSX.
Three Linux builds are working, trying to add OSX. I am going to make sure all basic varieties work, then will try to replicate some of the testing old CI used to do. I am not going to wait for this - will check tomorrow. With this much variety we are getting close to the number of jobs Azure allows for free - after 10 jobs are launched the rest would have to wait their turn. |
The macOS debug build is failing all the tests but rather than saying it's failed it's carrying on failing over and over. Two problems to solve:
EDIT: the test failures are this issue: #5876 it's a long standing problem with PAL that surfaces in macOS shared debug builds - the old CI dodged it by using a static build. |
The test runner tries to run until the end. I will set up a timeout - I was hoping Azure would kill it, but it did not.
Thank you for finding it! Converting the build to static should be a relatively easy fix. |
I wonder if we could/should add a "terminate on failure" flag to runtests.py or even make that the default behaviour with a flag to cancel it if you want to find multiple failures offline. I could have a look at how to do that. |
Maybe - I think it is useful to see all failures, though we can fail on the first one if it is too expensive to keep running. I wondering why the 'nix testing is slower - maybe we can improve the script somehow. |
68d2924
to
0defab7
Compare
This does not seem to help, not sure what I am doing wrong. |
Prevent tests from failing on OSX debug builds, by setting timeouts and forcing static library build. Shared library issue is described in chakra-core#5876.
0defab7
to
f10d36e
Compare
Fix environment variable reference. Remove debug output.
Turns out I had brackets around an environment variable name :) |
Enable building and testing via a single target (check) - require chakracore
library to be built before the test run.
For #6547