Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param scope and body scope should not be merged on this case. #6290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Param scope and body scope should not be merged on this case. #6290

wants to merge 1 commit into from

Commits on Sep 19, 2019

  1. Param scope and body scope should not be merged on this case. 

    When the param is used in the function, defined at the param scope, we should be have different param and body scope for the the enclosing function.
However we are using the function id from the top ref of the pidRefStack. This is not correct as we could have pushed a ref on the stack with different block id
but for the same function - so this logic could break.
For fixing that we should walk that pidRefStack to see if there is access to the inner function.
    @akroshg
    akroshg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    0e4a9f1 View commit details
    Browse the repository at this point in the history