Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bolt-cli revamp: add Dirk support #309

Merged
merged 16 commits into from
Oct 24, 2024
Merged

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Oct 22, 2024

starts #307

Overview

This PR adds support for Dirk as remote signer for generating BLS key delegations.
We can now list, unlock remote accounts and sign arbitrary data through the eth2-signer-api.

This PR comes with an e2e test using Dirk as a background process with pre-fabricated certificates and wallets.
To run the test, use the following command:

 cargo test --package bolt-cli --bin bolt-cli -- utils::dirk::tests::test_dirk_connection_e2e --exact --show-output --ignored

The guide can be found in the README here.

tasks:

  • update docs
  • more tests
  • auto re-lock accounts after signing

@merklefruit merklefruit changed the title feat: bolt-cli revamp feat: bolt-cli revamp: add Dirk support Oct 24, 2024
@merklefruit merklefruit marked this pull request as ready for review October 24, 2024 09:10
@merklefruit merklefruit added C: bolt-cli Component: bolt CLI T: feature Type: Feature labels Oct 24, 2024
@merklefruit merklefruit self-assigned this Oct 24, 2024
@merklefruit merklefruit added this to the v0.3: Holesky 1 milestone Oct 24, 2024
bolt-cli/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the renaming the code looks great! It's awesome there is also a test in the CI, great work.

bolt-cli/README.md Outdated Show resolved Hide resolved
@merklefruit merklefruit merged commit e1ce331 into unstable Oct 24, 2024
5 checks passed
@merklefruit merklefruit deleted the nico/feat/bolt-cli branch October 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-cli Component: bolt CLI T: feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants