chore: rabbit review

bolt-sidecar/bin/sidecar.rs

@@ -92,14 +92,13 @@ async fn main() -> eyre::Result<()> {
                     "Validation against execution state passed"
                 );
 
-                // TODO: review all this `clone` usage
-
                 // parse the request into constraints and sign them with the sidecar signer
-                let message = ConstraintsMessage::build(validator_index, request.clone());
+                let slot = request.slot;
+                let message = ConstraintsMessage::build(validator_index, request);
                 let signature = signer.sign(&message.digest())?.to_string();
                 let signed_constraints = SignedConstraints { message, signature };
 
-                execution_state.add_constraint(request.slot, signed_constraints.clone());
+                execution_state.add_constraint(slot, signed_constraints.clone());
 
                 let res = serde_json::to_value(signed_constraints).map_err(Into::into);
                 let _ = response_tx.send(res).ok();
@@ -142,7 +141,6 @@ async fn main() -> eyre::Result<()> {
                     }
                 }
 
-
                 if let Err(e) = local_builder.build_new_local_payload(&template).await {
                     tracing::error!(err = ?e, "CRITICAL: Error while building local payload at slot deadline for {slot}");
                 };

bolt-sidecar/src/client/rpc.rs

@@ -274,7 +274,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_smart_contract_code() -> eyre::Result<()> {
-        let rpc_url = Url::parse("https://cloudflare-eth.com")?;
+        let rpc_url = Url::parse(std::env::var("RPC_URL").unwrap().as_str())?;
         let rpc_client = RpcClient::new(rpc_url);
 
         // random deployed smart contract address