Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed wrong command in developing modules (3.24) #3369

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Changed wrong command in developing modules (3.24) #3369

merged 1 commit into from
Dec 9, 2024

Conversation

victormlg
Copy link
Contributor

Ticket: CFE-4457
Signed-off-by: Victor Moene [email protected]
(cherry picked from commit 406c16f)

@victormlg
Changed wrong command in developping modules
bc1ae77 
Ticket: CFE-4457
Signed-off-by: Victor Moene <[email protected]>
(cherry picked from commit 406c16f)
@victormlg victormlg mentioned this pull request Dec 9, 2024
Merged
@victormlg victormlg changed the title Changed wrong command in developping modules Changed wrong command in developping modules (3.24) Dec 9, 2024
@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-3.24/29/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-3.24-29/output/_site/

@craigcomstock craigcomstock changed the title Changed wrong command in developping modules (3.24) Changed wrong command in developing modules (3.24) Dec 9, 2024
craigcomstock
craigcomstock previously requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/developping/developing/ :) I already changed it in the PR title but please change in your commit as well.

Thanks!

@olehermanse
Copy link
Member

s/developping/developing/ :) I already changed it in the PR title but please change in your commit as well.

@craigcomstock this is a cherry-pick, too late to adjust the commit message in the original commit, I think it's okay / better to keep it as is here.

olehermanse
olehermanse approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI succeeded, preview looks good, merging.

@olehermanse olehermanse merged commit 675328f into cfengine:3.24 Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehermanse olehermanse olehermanse approved these changes

@craigcomstock craigcomstock craigcomstock left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victormlg @olehermanse @cf-bottom @craigcomstock