Added connect command #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Moene <[email protected]> Ticket: ENT-5726
olehermanse
requested changes
Jan 14, 2025
| @@ -274,6 +274,11 @@ def _get_arg_parser(): | |||
| ) | |||
| sp.add_argument("--bootstrap", "-B", help="Which hub to bootstrap to", type=str) | |||
|
|
|||
| sp = subp.add_parser("connect", help="Opens interactive ssh shell") | |||
| sp.add_argument( | |||
| "-hosts", "-H", help="Host to open the shell on", type=str, required=True | |||
There was a problem hiding this comment.
Suggested change
| "-hosts", "-H", help="Host to open the shell on", type=str, required=True | |
| "--hosts", "-H", help="Host to open the shell on", type=str, required=True |
Comment on lines
+637
to
+660
| @auto_connect | ||
| def open_shell(host, connection=None): | ||
| print("Enter 'exit' to log out\n") | ||
|
|
||
| cmd = "" | ||
| while cmd != "exit": | ||
| try: | ||
| cmd = input("\033[92m{}\033[00m :~ $ ".format(host)) | ||
| result = connection.run(cmd, hide=True) | ||
|
|
||
| if cmd == "exit": | ||
| pass | ||
| elif result.retcode == 0: | ||
| print(result.stdout.strip().strip("\n")) | ||
| else: | ||
| print(result.stderr.strip("\n")) | ||
| except KeyboardInterrupt: | ||
| print() | ||
| continue | ||
| except EOFError: | ||
| print() | ||
| return 0 | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
Did you try just launching ssh, instead of "implementing" a new shell like this?
https://stackoverflow.com/questions/3692387/start-interactive-ssh-session-from-python-script
I know it might be a bit tricky to get it to work, but might be worth it if it's not too hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like subprocess.Popen doesn't allow changing another process' working directory, so the command "cd" doesn't do anything. I feel like keeping track of the current directory would make the code overly complicated when the user can just use tricks like "cd some/dir && command ..."
Currently, it only allows connecting to a single host