Skip to content

Commit

Permalink
Pin exact Haploflow version
Browse files Browse the repository at this point in the history
Note that I am using a specific commit version for pinning.
Rationalization:

Haploflow is not developed actively, and because of that,
the last release is quite far behind master.

Thus, I think it's better to pin its version to the current master
than to the latest release tag.
  • Loading branch information
Donaim committed Sep 19, 2023
1 parent c621522 commit ce701e6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ jobs:
sudo apt-get install -y build-essential git ronn
cd /opt/
git clone https://github.com/hzi-bifo/Haploflow
cd /opt/Haploflow && sh build.sh
cd Haploflow
git checkout 9a5a0ff6c3a0435e723e41f98fe82ec2ad19cf50
sh build.sh
sudo ln -s /opt/Haploflow/build/haploflow ~/bin/haploflow
- name: Install IVA assembler dependencies
Expand Down
8 changes: 5 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ RUN apt-get install -q -y zlib1g-dev libncurses5-dev libncursesw5-dev && \

## Install Haploflow
RUN apt-get install -y build-essential sudo git ronn \
cd /opt/ &&
git clone https://github.com/hzi-bifo/Haploflow \
cd /opt/Haploflow && sh build.sh \
cd /opt/ && \
git clone https://github.com/hzi-bifo/Haploflow && \
cd Haploflow && \
git checkout 9a5a0ff6c3a0435e723e41f98fe82ec2ad19cf50 && \
sh build.sh && \
ln -s /opt/Haploflow/build/haploflow /bin/haploflow

## Install dependencies for genetracks/drawsvg
Expand Down

0 comments on commit ce701e6

Please sign in to comment.