ExpressionTransformer #1917: turns out we need the whole erasure boxi…

…ng rules for assignment now

Otherwise we get things like

Type x = (Type)
let(
Object tmpvar = nothing;
y = tmpvar; // here we need to add the (Type) cast as well
)
returning tmpvar;

for Type x, y; x = y = nothing

src/com/redhat/ceylon/compiler/java/codegen/ExpressionTransformer.java

@@ -2409,8 +2409,7 @@ private JCExpression transformAssignAndReturnOperation(Node operator, Tree.Term
             // make sure the result is unboxed if necessary, $tmp may be boxed
             JCExpression value = make().Ident(varName);
             BoxingStrategy boxingStrategy = CodegenUtil.getBoxingStrategy(term);
-            value = boxUnboxIfNecessary(value, boxResult, term.getTypeModel(), boxingStrategy);
-            value = applyJavaTypeConversions(value, returnType, valueType, boxingStrategy, boxResult, 0);
+            value = applyErasureAndBoxing(value, returnType, boxResult, boxingStrategy, valueType);
             JCExpression assignment = transformAssignment(operator, term, value);
             stats = stats.prepend(at(operator).Exec(assignment));
 
@@ -2452,8 +2451,7 @@ else if(term instanceof Tree.QualifiedMemberExpression){
             // make sure $tmpV is unboxed if necessary
             JCExpression value = make().Ident(varVName);
             BoxingStrategy boxingStrategy = CodegenUtil.getBoxingStrategy(term);
-            value = boxUnboxIfNecessary(value, boxResult, term.getTypeModel(), boxingStrategy);
-            value = applyJavaTypeConversions(value, returnType, valueType, boxingStrategy, boxResult, 0);
+            value = applyErasureAndBoxing(value, returnType, boxResult, boxingStrategy, valueType);
             JCExpression assignment = transformAssignment(operator, term, isSuper ? transformSuper(qualified) : make().Ident(varEName), value);
             stats = stats.prepend(at(operator).Exec(assignment));