Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line: Add centroid anchor #602

Merged
merged 3 commits into from
Aug 13, 2024
Merged

line: Add centroid anchor #602

merged 3 commits into from
Aug 13, 2024

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented May 21, 2024 •
edited
Loading

This adds a centroid anchor to closed lines (polygons) and merge-path.

@johannes-wolf johannes-wolf changed the base branch from master to projection-enhancements July 19, 2024 21:08
@johannes-wolf johannes-wolf force-pushed the polygon-center branch 5 times, most recently from 4c23ddf to 9a4b148 Compare July 23, 2024 21:13
jamesrswift
jamesrswift approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@jamesrswift jamesrswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you are trying to find a name, it might be "centre of gravity" by the looks of it (but it has been a while since I studied geometry)

@fenjalien fenjalien added this to the 0.3.0 milestone Aug 7, 2024
@johannes-wolf johannes-wolf force-pushed the projection-enhancements branch 2 times, most recently from 76c6d54 to 1eadadf Compare August 9, 2024 18:31
@johannes-wolf johannes-wolf force-pushed the polygon-center branch 4 times, most recently from f1d38ee to dbf7333 Compare August 9, 2024 18:39
fenjalien
fenjalien requested changes Aug 11, 2024
View reviewed changes
src/draw/shapes.typ Outdated Show resolved Hide resolved
src/draw/shapes.typ Outdated Show resolved Hide resolved
src/draw/shapes.typ Outdated Show resolved Hide resolved
src/draw/shapes.typ Outdated Show resolved Hide resolved
src/polygon.typ Show resolved Hide resolved
@johannes-wolf johannes-wolf changed the title line: Add center anchor line: Add centroid anchor Aug 11, 2024
@fenjalien
Copy link
Member

I think you've messed up the git history again

@johannes-wolf johannes-wolf changed the base branch from projection-enhancements to master August 12, 2024 14:19
@johannes-wolf johannes-wolf merged commit 74bd0d4 into master Aug 13, 2024
1 check passed
@johannes-wolf johannes-wolf deleted the polygon-center branch August 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenjalien fenjalien fenjalien approved these changes

@jamesrswift jamesrswift jamesrswift approved these changes

Assignees
No one assigned
Labels
core:draw ✏️
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johannes-wolf @fenjalien @jamesrswift