This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 226
Update LDAP parameters #280
Open
dtrdnk
wants to merge
3
commits into
cetic:master
Choose a base branch
from
dtrdnk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrdnk
force-pushed
the
master
branch
2 times, most recently
from
December 6, 2022 14:56
166bee6
to
f7c9072
Compare
dtrdnk
changed the title
Fix authorizers parameters. Add some values for full example. Add env…
Update LDAP parameters
Dec 6, 2022
dtrdnk
force-pushed
the
master
branch
3 times, most recently
from
December 10, 2022 08:50
67606f2
to
750a0af
Compare
* Add few new parameters in 03-ldap-values.yaml for test * Add envFrom for loading env from secrets, and subsets them * Upgrade app version * Fix format for nifi.provenance.repository.debug.frequency * Add comments for ingress in values.yaml * Fix hardcoded busybox image tag in ca app * Fix hardcoded ldap parameters in authorizers.xml * Add logback.xml for log level * Fix hardcode and add new parameters in login-identity-providers-ldap.xml * Update hardcode and add new parameters in nifi.properties * Replace command cat to envsubst for using env vars aka source of params in configs * Update app version * Add clusterDomain aka global parameter * Update README * Remove file-provider in authorizers.xml, and set composite-configurable-user-group-provider * fix hardcoded schema for registry url * fix sa name for nifi app
cf250024
reviewed
Jun 3, 2023
repository: apache/nifi | ||
tag: "1.16.3" | ||
pullPolicy: "IfNotPresent" | ||
repository: dmitriidmnk/nifi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using apache/nifi
cf250024
reviewed
Jun 3, 2023
httpsPort: 8443 | ||
webProxyHost: # <clusterIP>:<NodePort> (If Nifi service is NodePort or LoadBalancer) | ||
webProxyHost: # 'nifi.default.svc.cluster.local:8443' uncomment and edit, if replicaCount more than 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the domain name for the ingress.
cf250024
reviewed
Jun 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to make the only changes to address the problems we face with ldap. Remove those changes related to ingress for example. I have trouble to make ldap working for me and I'm looking for any fixed related to this. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…From for loading env from secrets, and subsets them. Fix LDAP parameters
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]