-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how to install cert-manager using ArgoCD #1447
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: shahkv95 <[email protected]>
Signed-off-by: shahkv95 <[email protected]>
Signed-off-by: shahkv95 <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
```yaml | ||
# application.yaml | ||
apiVersion: argoproj.io/v1alpha1 | ||
kind: Application | ||
metadata: | ||
name: cert-manager | ||
namespace: argocd | ||
annotations: | ||
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
finalizers: | ||
- resources-finalizer.argocd.argoproj.io | ||
spec: | ||
destination: | ||
namespace: cert-manager | ||
server: https://kubernetes.default.svc | ||
project: default | ||
source: | ||
chart: cert-manager | ||
repoURL: https://charts.jetstack.io | ||
targetRevision: [[VAR::cert_manager_latest_version]] | ||
helm: | ||
values: | | ||
installCRDs: true | ||
syncPolicy: | ||
automated: | ||
prune: true | ||
selfHeal: true | ||
syncOptions: | ||
- CreateNamespace=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This still has to be verified
Normally by using ServerSideApply and ServerSide diffing, there should be no issues with mutating webhooks:
```yaml | |
# application.yaml | |
apiVersion: argoproj.io/v1alpha1 | |
kind: Application | |
metadata: | |
name: cert-manager | |
namespace: argocd | |
annotations: | |
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | |
finalizers: | |
- resources-finalizer.argocd.argoproj.io | |
spec: | |
destination: | |
namespace: cert-manager | |
server: https://kubernetes.default.svc | |
project: default | |
source: | |
chart: cert-manager | |
repoURL: https://charts.jetstack.io | |
targetRevision: [[VAR::cert_manager_latest_version]] | |
helm: | |
values: | | |
installCRDs: true | |
syncPolicy: | |
automated: | |
prune: true | |
selfHeal: true | |
syncOptions: | |
- CreateNamespace=true | |
```yaml | |
# application.yaml | |
apiVersion: argoproj.io/v1alpha1 | |
kind: Application | |
metadata: | |
name: cert-manager | |
namespace: argocd | |
annotations: | |
argocd.argoproj.io/compare-options: ServerSideDiff=true | |
finalizers: | |
- resources-finalizer.argocd.argoproj.io | |
spec: | |
destination: | |
namespace: cert-manager | |
server: https://kubernetes.default.svc | |
project: default | |
source: | |
chart: cert-manager | |
repoURL: https://charts.jetstack.io | |
targetRevision: [[VAR::cert_manager_latest_version]] | |
helm: | |
values: | | |
installCRDs: true | |
syncPolicy: | |
automated: | |
prune: true | |
selfHeal: true | |
syncOptions: | |
- CreateNamespace=true | |
- ServerSideApply=true |
This change is based on https://argo-cd.readthedocs.io/en/stable/user-guide/diff-strategies/ and https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#server-side-apply.
Preview: https://deploy-preview-1447--cert-manager-website.netlify.app/docs/installation/continuous-deployment-and-gitops/#using-argocd
Continuing the work @shahkv95 started in #1350
Some months later, in #1350 (comment) @Tokynet wrote:
So, in response to that, I've created this PR in which I've implemented the changes that I suggested in #1350 (review) and rebased on top of latest origin/master.
@Tokynet Please either review and make suggestions in thie PR, or branch from wallrj:cert-manager-argocd and continue the work on your own branch, create your own PR and then ping me for