Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add peer recon ring #616

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: add peer recon ring #616

merged 3 commits into from
Dec 5, 2024

Conversation

nathanielc
Copy link
Collaborator

With this change there is now a Recon ring for sharing information about
peers. Peers will synchronized all known peers with connected peers.
Each peer will self-publish into the ring periodically.

Fixes: #604
Fixes: #607

@nathanielc nathanielc requested review from a team, stbrody and dav1do as code owners November 25, 2024 18:06
@nathanielc nathanielc requested review from stephhuynh18 and removed request for a team November 25, 2024 18:06
@nathanielc nathanielc marked this pull request as draft November 25, 2024 18:06
dav1do
dav1do reviewed Nov 26, 2024
View reviewed changes
core/src/peer.rs Outdated Show resolved Hide resolved
core/src/peer.rs Outdated Show resolved Hide resolved
peer-svc/src/store/sql/access/peer.rs Show resolved Hide resolved
peer-svc/src/store/sql/access/peer.rs Outdated Show resolved Hide resolved
peer-svc/src/store/sql/access/version.rs Outdated Show resolved Hide resolved
peer-svc/src/service.rs Outdated Show resolved Hide resolved
p2p/src/peers.rs Show resolved Hide resolved
@nathanielc nathanielc force-pushed the feat/peer-recon-ring branch 2 times, most recently from 5b74e9d to 9e8d80e Compare November 26, 2024 21:14
dav1do
dav1do reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is still marked draft and my previous comments (nits) are still open. It's a lot of code but it all seems to follow the established patterns so I don't have anything major right now.

recon/src/libp2p.rs Show resolved Hide resolved
p2p/src/node.rs Show resolved Hide resolved
recon/src/libp2p.rs Show resolved Hide resolved
Base automatically changed from feat/peer-entry to main December 4, 2024 15:34
@nathanielc
feat: add peer recon ring
978ec00 
With this change there is now a Recon ring for sharing information about
peers. Peers will synchronized all known peers with connected peers.
Each peer will self-publish into the ring periodically.

Fixes: #604
Fixes: #607
@nathanielc
update for offset/limit changes
d9cdbec
@nathanielc nathanielc force-pushed the feat/peer-recon-ring branch from 4892678 to d9cdbec Compare December 4, 2024 22:04
@nathanielc nathanielc marked this pull request as ready for review December 4, 2024 22:04
@nathanielc nathanielc requested a review from dav1do December 4, 2024 22:06
@nathanielc nathanielc added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c1e7545 Dec 5, 2024
5 checks passed
@nathanielc nathanielc deleted the feat/peer-recon-ring branch December 5, 2024 20:49
@smrz2001 smrz2001 mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav1do dav1do dav1do approved these changes

@stbrody stbrody Awaiting requested review from stbrody stbrody is a code owner

@stephhuynh18 stephhuynh18 Awaiting requested review from stephhuynh18 stephhuynh18 is a code owner automatically assigned from ceramicnetwork/eng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielc @dav1do