feat: default swarm port #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
reviewed
Oct 30, 2023
one/src/main.rs
Outdated
| @@ -61,7 +61,7 @@ struct DaemonOpts { | |||
| /// Listen address of the p2p swarm. | |||
| #[arg( | |||
| long, | |||
| default_values_t = vec!["/ip4/0.0.0.0/tcp/0".to_string(), "/ip4/0.0.0.0/udp/0/quic-v1".to_string()], | |||
| default_values_t = vec!["/ip4/0.0.0.0/tcp/4001".to_string(), "/ip4/0.0.0.0/udp/4001/quic-v1".to_string()], | |||
There was a problem hiding this comment.
Can we run both tcp and quic on a single port?
There was a problem hiding this comment.
Yes they are TCP vs UDP and so can use the same port number.
There was a problem hiding this comment.
Thanks, I was suspecting this but wasn't sure!
nathanielc
approved these changes
Oct 30, 2023
one/src/main.rs
Outdated
| @@ -61,7 +61,7 @@ struct DaemonOpts { | |||
| /// Listen address of the p2p swarm. | |||
| #[arg( | |||
| long, | |||
| default_values_t = vec!["/ip4/0.0.0.0/tcp/0".to_string(), "/ip4/0.0.0.0/udp/0/quic-v1".to_string()], | |||
| default_values_t = vec!["/ip4/0.0.0.0/tcp/4001".to_string(), "/ip4/0.0.0.0/udp/4001/quic-v1".to_string()], | |||
There was a problem hiding this comment.
Yes they are TCP vs UDP and so can use the same port number.
oed
approved these changes
Oct 30, 2023
AaronGoldman
force-pushed
the
feat/p2p-swarm-listen-port
branch
from
98e2b9b to
7c24430
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
CERAMIC_ONE_SWARM_ADDRESSES default_values port 4001
AaronGoldman
force-pushed
the
feat/p2p-swarm-listen-port
branch
from
7c24430 to
370cbcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CERAMIC_ONE_SWARM_ADDRESSES default_values port 4001