Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orders report #2578

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Add orders report #2578

merged 10 commits into from
Jan 20, 2025
+298 −13

Conversation

kattylucy
Copy link
Collaborator

  • Add new order reports

#2109

@kattylucy kattylucy requested a review from onnovisser January 14, 2025 14:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2578.k-f.dev
Commit #: 2fd563a
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2578-app-ff-production.k-f.dev
Commit #: 2fd563a
To access the functions directly check the corresponding deploy Action

@mustermeiszer
Copy link
Contributor

mustermeiszer commented Jan 16, 2025 •
edited
Loading

Could we make the ordering descending from Date & Time the default?

image

@mustermeiszer
Copy link
Contributor

mustermeiszer commented Jan 16, 2025 •
edited
Loading

Some numbers are missing. Is this an indexing issue?

image

@mustermeiszer
Copy link
Contributor

mustermeiszer commented Jan 16, 2025 •
edited
Loading

Would remove the date here.

image

@mustermeiszer
Copy link
Contributor

Sorting after epoch is off

Descending:
image

Ascending:
image

mustermeiszer
mustermeiszer approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the product side. Should still wait code-wise for Sophia or Onno. But thanks, that is really, really helping a lot!

Regarding the inconsistent data I will discuss with Jeroen and Graham. Not relevant for this PR.

sophialittlejohn
sophialittlejohn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work Katty 🔥

@kattylucy kattylucy merged commit d902694 into main Jan 20, 2025
13 checks passed
@kattylucy kattylucy deleted the 2109_orders_report branch January 20, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

@onnovisser onnovisser Awaiting requested review from onnovisser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattylucy @mustermeiszer @sophialittlejohn