Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets table quantity and pagination #2560

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix assets table quantity and pagination #2560

merged 3 commits into from
Dec 18, 2024

Conversation

kattylucy
Copy link
Collaborator

Fix assets table quantity and pagination

#2558

@kattylucy kattylucy requested a review from hieronx December 18, 2024 11:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2560.k-f.dev
Commit #: 6fe9f06
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2560-app-ff-production.k-f.dev
Commit #: 6fe9f06
To access the functions directly check the corresponding deploy Action

@hieronx
Copy link
Contributor

hieronx commented Dec 18, 2024

Somehow this is messing up the summary card denominations:

Screenshot 2024-12-18 at 13 31 38

See https://pr2560-app-ff-production.k-f.dev/#/pools/4139607887/assets

hieronx
hieronx approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@kattylucy kattylucy merged commit 7cba4b7 into main Dec 18, 2024
13 checks passed
@kattylucy kattylucy deleted the fix_assets_table_qt branch December 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieronx hieronx hieronx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @hieronx