Create pool - functionality #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
Base automatically changed from
create_pool_structure
to
create_pool_redesign
November 27, 2024 15:29
kattylucy
force-pushed
the
create_pool_functionality
branch
from
41696cc to
d5c9bd3
Compare
kattylucy
force-pushed
the
create_pool_functionality
branch
from
d5c9bd3 to
36cd71c
Compare
kattylucy
force-pushed
the
create_pool_functionality
branch
from
121e56e to
945bf45
Compare
onnovisser
reviewed
Dec 3, 2024
| @@ -40,20 +40,28 @@ export const IssuerCategoriesSection = () => { | |||
| <> | |||
| {form.values.issuerCategories.map((_, index) => ( | |||
There was a problem hiding this comment.
now that it's used, better to give _ a name
kattylucy
force-pushed
the
create_pool_functionality
branch
from
9e9f599 to
b0f5982
Compare
| label="Reviewer avatar" | ||
| placeholder="Choose file" | ||
| accept="image/*" |
There was a problem hiding this comment.
I would limit the file types even more, e/g accept="image/png, image/jpeg, image/jpg"
kattylucy
added a commit
that referenced
this pull request
Dec 13, 2024
* Fix ts error and change logic for onboarding values * Add create pool existing functionality * Cleanup types * cleanup * Add deposit banner * Fix linter errors * Add metadata values * Cleanup types * Add onboarding functionality and UI fixes * Add proxies functionality * Fix ts errors * Add create pool dialog * Add dialogs * Add review feedback * wip * Add waiting before redirecting to avoid error * Remove default empty pool fee
kattylucy
added a commit
that referenced
this pull request
Dec 17, 2024
* Fix ts error and change logic for onboarding values * Add create pool existing functionality * Cleanup types * cleanup * Add deposit banner * Fix linter errors * Add metadata values * Cleanup types * Add onboarding functionality and UI fixes * Add proxies functionality * Fix ts errors * Add create pool dialog * Add dialogs * Add review feedback * wip * Add waiting before redirecting to avoid error * Remove default empty pool fee
kattylucy
added a commit
that referenced
this pull request
Dec 18, 2024
* Fabric changes * Type updates * Add new create pool index * Add pool structure section * Fix sidebar * Add pool details section * Add pool setup section * Minor UI fix * Pool structure - create pool (#2543) * Add pool structure UI changes * Small UI fix * Avoid deletion on entries if less than one * Add logic to single / multi sign * Fix linter errors * Create pool - functionality (#2545) * Fix ts error and change logic for onboarding values * Add create pool existing functionality * Cleanup types * cleanup * Add deposit banner * Fix linter errors * Add metadata values * Cleanup types * Add onboarding functionality and UI fixes * Add proxies functionality * Fix ts errors * Add create pool dialog * Add dialogs * Add review feedback * wip * Add waiting before redirecting to avoid error * Remove default empty pool fee * Create pool bugs and fixes (#2550) * Bug fixes and add proposal link * Fix ratings creating empty value * Update fabric/src/theme/tokens/colors.ts Co-authored-by: Sophia <[email protected]> * Update centrifuge-app/src/pages/IssuerCreatePool/IssuerCategories.tsx Co-authored-by: Sophia <[email protected]> * Update centrifuge-app/src/pages/IssuerCreatePool/PoolSetupSection.tsx Co-authored-by: Sophia <[email protected]> * Add feedback * feedback * Feedback changes * Add feeback * Fix tranches apy APY should be based on junior token * Add feeback * Fix placeholder color * Replace file upload with image upload * Bug fixes * Code review feedback * Add jay's feedback and cleanup * Update centrifuge-app/src/components/Menu/IssuerMenu.tsx Co-authored-by: Onno Visser <[email protected]> * Update centrifuge-app/src/pages/IssuerCreatePool/validate.ts Co-authored-by: Onno Visser <[email protected]> * Update centrifuge-app/src/pages/IssuerCreatePool/validate.ts Co-authored-by: Onno Visser <[email protected]> * Rebase issue --------- Co-authored-by: Sophia <[email protected]> Co-authored-by: Onno Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of pool redesign
#2529
Approvals