Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archived pools toggle #2004

Merged
merged 4 commits into from
Mar 13, 2024
Merged

archived pools toggle #2004

merged 4 commits into from
Mar 13, 2024

Conversation

onnovisser
Copy link
Collaborator

Description

Adds separate table with archived pools and a toggle to show/hide them

#1905

Approvals

  • Dev

Screenshots

image

Impact

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Only issue I see is that the table headers are still visible even if there are no archived pools

@onnovisser
Copy link
Collaborator Author

@sophialittlejohn fixed

@onnovisser onnovisser enabled auto-merge (squash) March 13, 2024 12:46
@onnovisser onnovisser merged commit ef135ab into main Mar 13, 2024
8 checks passed
@onnovisser onnovisser deleted the archived-pools branch March 13, 2024 12:48
Copy link

PR deployed in Google Cloud
URL: https://app-pr2004.k-f.dev
Commit #: e1a2805
To access the functions directly check the corresponding deploy Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants