Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency dropdown for lp investments #1980

Merged
merged 52 commits into from
Apr 2, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Feb 24, 2024

Description

This pull request...

  • enables mutli currency in lp pools by making the input always available even with open orders so that you can switch between currencies
  • splits up the InvestRedeem.tsx component into InvestForm.tsx RedeemForm.tsx PendingOrder.tsx utils.ts and a few more

#1901

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

onnovisser and others added 24 commits January 31, 2024 10:39
* Add pool fee tab and table with drawers for edit and charging fees

* Add UI of form to charge fees

* Update links

* Add successful submit state to charge order

* Fetch pool fee data from onchain

* Update styles of Drawer header

* Enable setting pool fee charge

* Fix update order

* Remove logs

* Add functionality for edit fees drawer

* Update metadata when editing pool fees

* Query proposed changes

* Fix metadata update when item is not being removed

* Clean up

* Hide edit fee structure button for non admins

* Remove unused var

* Update styles

* Support LP in holders & investor tx reporting (#1912)

* Update

* Fix

* wip

* Fix address format

* Improve

* Naming

* Add investor tx type filter

* Disable oracles (#1916)

---------

Co-authored-by: Jeroen <[email protected]>
Co-authored-by: Onno Visser <[email protected]>
* Add pool fees to create pool form

* Add create fees to create pool

* Add treasury account

* Update formik to resolve type errors

* Align all columns to the left

* Add fees tab to issuer pool

* Fix gray background to full width
* Fix button spacing in holdings

* Update font color of tertiary button

* Use tertiary buttons for poolfees table

* Show actions only to allowed viewers

* Handle cancel better on update fee charge

* Update label

* Add pool type input to create pool

* Add validation for new input

* Set correct default fees based on poolType

* Add ~ to pending fees

* Add pending fees for fixed fees

* Fix tilde logic

* Fix balance types

* Account for epoch time if limit is amountPerSecond

* Use last nav for pending fee calculation

* Clean up naming

* Remove ~ and add pending fees to fixed fee calc

* Fix input jumping

* Fix multiply by zero on first epoch where previous nav is 0

* Remove logs

* Add type decorations for nav runtime api

* Fix PoolNav types

* Fetch nav value from runtime instead of chain storage

* Fix decimal error in fees
* Fix typo in tooltip

* Place pool type next to pool name
sophialittlejohn and others added 5 commits February 26, 2024 10:36
* Add copy to clipboard to receiving address in table

* Add total pending fees to page summary

* Show action column only to receiving address and pool admins

* Use maxPayable as amount for non fixed charges

* Add fee position column and numbered fees

* Fix disabled dropdown label

* Rename protocol fees

* Add tooltip to fee type label

* Add fee position to metadata and update label of fixed fee input

* Ajust edit fees drawer

* Rename title in charge fees drawer

* Remove log

* Add * to required fields in create pool form

* Update centrifuge-app/src/pages/IssuerCreatePool/PoolFeeInput.tsx

* Fix fixed pending fees

* Prettier

* Fix reserve in chart

---------

Co-authored-by: JP <[email protected]>
@sophialittlejohn sophialittlejohn changed the base branch from main to runtime-upgrade-1038 March 12, 2024 21:06
Base automatically changed from runtime-upgrade-1038 to main March 18, 2024 16:32
Copy link

github-actions bot commented Mar 26, 2024

PR deployed in Google Cloud
URL: https://app-pr1980.k-f.dev
Commit #: b3b472c
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Mar 27, 2024

PR deployed in Google Cloud
URL: https://pr1980-app-ff-production.k-f.dev
Commit #: b3b472c
To access the functions directly check the corresponding deploy Action

@sophialittlejohn sophialittlejohn enabled auto-merge (squash) April 2, 2024 17:33
@sophialittlejohn sophialittlejohn merged commit 7fb1ca6 into main Apr 2, 2024
11 checks passed
@sophialittlejohn sophialittlejohn deleted the select-for-lp-investments branch April 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants