Pool fees feedback #1975
Merged
Pool fees feedback #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o pool-fees-feedback
jpangelle
reviewed
Feb 23, 2024
jpangelle
approved these changes
Feb 23, 2024
…o pool-fees-feedback
…pool-fees-feedback
…o pool-fees-feedback
|
PR deployed in Google Cloud |
sophialittlejohn
added a commit
that referenced
this pull request
Mar 18, 2024
* Oracle Feeders (#1880) * Pool fees (#1903) * Add pool fee tab and table with drawers for edit and charging fees * Add UI of form to charge fees * Update links * Add successful submit state to charge order * Fetch pool fee data from onchain * Update styles of Drawer header * Enable setting pool fee charge * Fix update order * Remove logs * Add functionality for edit fees drawer * Update metadata when editing pool fees * Query proposed changes * Fix metadata update when item is not being removed * Clean up * Hide edit fee structure button for non admins * Remove unused var * Update styles * Support LP in holders & investor tx reporting (#1912) * Update * Fix * wip * Fix address format * Improve * Naming * Add investor tx type filter * Disable oracles (#1916) --------- Co-authored-by: Jeroen <[email protected]> Co-authored-by: Onno Visser <[email protected]> * fix types * Add pool fees to create pool form (#1920) * Add pool fees to create pool form * Add create fees to create pool * Add treasury account * Update formik to resolve type errors * Align all columns to the left * Add fees tab to issuer pool * Fix gray background to full width * Add pool analysis section to Create Pool form (#1939) * Pool fees follow up (#1933) * Fix button spacing in holdings * Update font color of tertiary button * Use tertiary buttons for poolfees table * Show actions only to allowed viewers * Handle cancel better on update fee charge * Update label * Add pool type input to create pool * Add validation for new input * Set correct default fees based on poolType * Add ~ to pending fees * Add pending fees for fixed fees * Fix tilde logic * Fix balance types * Account for epoch time if limit is amountPerSecond * Use last nav for pending fee calculation * Clean up naming * Remove ~ and add pending fees to fixed fee calc * Fix input jumping * Fix multiply by zero on first epoch where previous nav is 0 * Remove logs * Add type decorations for nav runtime api * Fix PoolNav types * Fetch nav value from runtime instead of chain storage * Fix decimal error in fees * force workflows on this branch (revert this before merging) * Revert workflow updates * Add regex for PRs in pinning * Temp fix for asset page * Add back oracle price form that got lost in merge conflict * Pool type follow up (#1963) * Fix typo in tooltip * Place pool type next to pool name * Swaps: Fulfill orders with market prices (#1966) * remove old oracle stuff * Fix asset value and nav calc (#1967) * Fix bug in create pool form * fix demo pod url * Parse hex to BN to fix demo pools * Fix breaking change since rt upgrade 1041 (#1979) * Remove deprecated orderBook.tradingPair query (#1981) * Pool fees feedback (#1975) * Add copy to clipboard to receiving address in table * Add total pending fees to page summary * Show action column only to receiving address and pool admins * Use maxPayable as amount for non fixed charges * Add fee position column and numbered fees * Fix disabled dropdown label * Rename protocol fees * Add tooltip to fee type label * Add fee position to metadata and update label of fixed fee input * Ajust edit fees drawer * Rename title in charge fees drawer * Remove log * Add * to required fields in create pool form * Update centrifuge-app/src/pages/IssuerCreatePool/PoolFeeInput.tsx * Fix fixed pending fees * Prettier * Fix reserve in chart --------- Co-authored-by: JP <[email protected]> * feat: add pool fees RtApi v1 & add Loans RtApi v2 & cleanup RPCs (#1954) * feat: add pool fees runtime api * fix: remove non-existent RPCs * feat: LoansApi v2 * fix runtime api * Fix typing * Fee reporting (#1994) * Set up fee tx reporting * Use fee id * Setup * Naming * Update centrifuge-app/src/components/Report/FeeTransactions.tsx Co-authored-by: Sophia <[email protected]> --------- Co-authored-by: Sophia <[email protected]> * Fix portfolio runtime call (#2018) * Add pool fees to pool detail page (#2015) * Upgrade packages in Centrifuge JS + Bump version (#2019) * Upgrade polkadot packages * Bump version * Upgrade deps in cent-app * Fix pool fees --------- Co-authored-by: Onno Visser <[email protected]> Co-authored-by: Jeroen <[email protected]> Co-authored-by: Onno Visser <[email protected]> Co-authored-by: Guillermo Perez <[email protected]> Co-authored-by: JP <[email protected]> Co-authored-by: William Freudenberger <[email protected]>
sophialittlejohn
added a commit
that referenced
this pull request
Apr 2, 2024
* Oracle Feeders (#1880) * Pool fees (#1903) * Add pool fee tab and table with drawers for edit and charging fees * Add UI of form to charge fees * Update links * Add successful submit state to charge order * Fetch pool fee data from onchain * Update styles of Drawer header * Enable setting pool fee charge * Fix update order * Remove logs * Add functionality for edit fees drawer * Update metadata when editing pool fees * Query proposed changes * Fix metadata update when item is not being removed * Clean up * Hide edit fee structure button for non admins * Remove unused var * Update styles * Support LP in holders & investor tx reporting (#1912) * Update * Fix * wip * Fix address format * Improve * Naming * Add investor tx type filter * Disable oracles (#1916) --------- Co-authored-by: Jeroen <[email protected]> Co-authored-by: Onno Visser <[email protected]> * fix types * Add pool fees to create pool form (#1920) * Add pool fees to create pool form * Add create fees to create pool * Add treasury account * Update formik to resolve type errors * Align all columns to the left * Add fees tab to issuer pool * Fix gray background to full width * Add pool analysis section to Create Pool form (#1939) * Pool fees follow up (#1933) * Fix button spacing in holdings * Update font color of tertiary button * Use tertiary buttons for poolfees table * Show actions only to allowed viewers * Handle cancel better on update fee charge * Update label * Add pool type input to create pool * Add validation for new input * Set correct default fees based on poolType * Add ~ to pending fees * Add pending fees for fixed fees * Fix tilde logic * Fix balance types * Account for epoch time if limit is amountPerSecond * Use last nav for pending fee calculation * Clean up naming * Remove ~ and add pending fees to fixed fee calc * Fix input jumping * Fix multiply by zero on first epoch where previous nav is 0 * Remove logs * Add type decorations for nav runtime api * Fix PoolNav types * Fetch nav value from runtime instead of chain storage * Fix decimal error in fees * force workflows on this branch (revert this before merging) * Revert workflow updates * Add regex for PRs in pinning * Temp fix for asset page * Add back oracle price form that got lost in merge conflict * Pool type follow up (#1963) * Fix typo in tooltip * Place pool type next to pool name * Swaps: Fulfill orders with market prices (#1966) * remove old oracle stuff * Fix asset value and nav calc (#1967) * Fix bug in create pool form * fix demo pod url * Parse hex to BN to fix demo pools * Fix breaking change since rt upgrade 1041 (#1979) * Add currency dropdown for lp investments * Remove deprecated orderBook.tradingPair query (#1981) * Tem deploy PR to demo * Pool fees feedback (#1975) * Add copy to clipboard to receiving address in table * Add total pending fees to page summary * Show action column only to receiving address and pool admins * Use maxPayable as amount for non fixed charges * Add fee position column and numbered fees * Fix disabled dropdown label * Rename protocol fees * Add tooltip to fee type label * Add fee position to metadata and update label of fixed fee input * Ajust edit fees drawer * Rename title in charge fees drawer * Remove log * Add * to required fields in create pool form * Update centrifuge-app/src/pages/IssuerCreatePool/PoolFeeInput.tsx * Fix fixed pending fees * Prettier * Fix reserve in chart --------- Co-authored-by: JP <[email protected]> * feat: add pool fees RtApi v1 & add Loans RtApi v2 & cleanup RPCs (#1954) * feat: add pool fees runtime api * fix: remove non-existent RPCs * feat: LoansApi v2 * fix runtime api * Fix typing * Trigger build * Set value explicitly * Add lock file * Split up components in InvestRedeem * Always show input in invest form + refactor * Enable testing investments with Sepolia * Simply and clean up InvestForm * Update redeem form --------- Co-authored-by: Onno Visser <[email protected]> Co-authored-by: Jeroen <[email protected]> Co-authored-by: Onno Visser <[email protected]> Co-authored-by: Guillermo Perez <[email protected]> Co-authored-by: JP <[email protected]> Co-authored-by: William Freudenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
#1943
Approvals
Screenshots
Impact