Centrifuge App: Disable permits for smart contract wallets #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
hieronx
reviewed
Dec 8, 2023
| lpInvest.currencySupportsPermit && | ||
| pendingAction !== 'approvePoolCurrency' | ||
| ) { | ||
| if (lpInvest.lpCurrencyAllowance.lt(newOrder) && supportsPermits && pendingAction !== 'approvePoolCurrency') { | ||
| const signer = provider!.getSigner() | ||
| const connectedCent = cent.connectEvm(evmAddress!, signer) | ||
| const permit = await connectedCent.liquidityPools.signPermit([ |
There was a problem hiding this comment.
I guess I'm missing something, but to me it looks like the else statement on line 195 is not actually doing an approve, and just requestDeposit?
There was a problem hiding this comment.
needsPoolCurrencyApproval will return true when !supportsPermits, which will cause the form submit button to call approvePoolCurrency first, here:
hieronx
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
Closes #
Approvals
Screenshots
Impact