Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async methods fix #41

Closed
wants to merge 9 commits into from
Closed

Async methods fix #41

wants to merge 9 commits into from

Conversation

vanelizarov
Copy link

Fixes #31

@vanelizarov vanelizarov deleted the async_methods_fix branch November 19, 2020 11:05
@LevinGermann
Copy link

Hi @vanelizarov
I don't see this merged to master, why has this been closed? I thought it would be a welcome change.

@vanelizarov
Copy link
Author

@LevinGermann hello! I've messed up updating my fork, will submit another PR a little bit later 🙂

@LevinGermann
Copy link

@vanelizarov Ah, got you. Thank you very much! 😊

@vanelizarov
Copy link
Author

@vanelizarov Ah, got you. Thank you very much! 😊

Fixed in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all async functions return a Future
2 participants
@vanelizarov @LevinGermann