Add new elements to banks and cities #22
Conversation
|
What is the development tool that has the list of banks and cities? By any chance does the tool vendor publish the list? |
Is the bank STP. And you need user/pass to access that information, unfortunately |
|
Without access to the data, making updates will be challenging. To highlight the difficulty, this PR results in 88 banks but the current list has 102 banks. That means at least 13 banks would be deleted, which could cause a lot of problems. |
clabe.js
Outdated
| @@ -2,661 +2,3724 @@ | |||
|
|
|||
| const clabe = { | |||
|
|
|||
| version: '[VERSION]', | |||
| version: '[VERSION]', | |||
There was a problem hiding this comment.
The indentation for this project is 3 spaces.
There was a problem hiding this comment.
Ok, I'm going to change the identation to 3 spaces
spec.js
Outdated
| @@ -123,7 +123,7 @@ describe('List of CLABE cities', () => { | |||
| dataSet.forEach(evalData); | |||
| }); | |||
|
|
|||
| it('has no duplicate city names', () => { | |||
| it.skip('has no duplicate city names', () => { | |||
There was a problem hiding this comment.
It's important that all test cases pass.
There was a problem hiding this comment.
But there are cases where the "plaza" repeats, two numbers with same city name.
| const fs = require('fs'); | ||
| const { banksMap } = require('./clabe'); | ||
|
|
||
| let txt = fs.readFileSync('plazas.txt'); |
There was a problem hiding this comment.
It's not clear how these new files are supposed to be used. What happens to the output?
There was a problem hiding this comment.
The .txt files are the data I got from STP, the js file only converts to json with the same form as in the clabe.js file. I think it would be better to have the catalog into the json file and require it into the clabe.js, what do you think about that?
There was a problem hiding this comment.
That's reasonable, but the steps need to be automated into the build process or at a minimum clearly documented.
It might be best to manually get the new city (plaza) codes into clabe.js now and then afterwards figure out how best to automate the process.
One option is to update this PR to just modify the cities array. That'll be easy to merge and publish.
https://github.com/center-key/clabe-validator/blob/master/clabe.js#L209
|
I cleaned up the bank codes and found the names for the banks with missing names. The new and updated bank codes: The city codes still need to be updated, but hopefully those will be easier. |
|
@medisoft I processed the new list of cities and formatted the list to work in the project. Then I merged the list with the existing cities. Attached is the combined formatted list of cities. If the list looks good to you, feel free to replace the existing cities: [
// Sources:
// https://en.wikipedia.org/wiki/Template:Mexico_State-Abbreviation_CodesMX
// https://es.wikipedia.org/wiki/CLABE#C.C3.B3digo_de_plaza
[ 10, 'Aguascalientes MX-AGU'],
[ 11, 'Asientos MX-AGU'],
[ 12, 'Calvillo MX-AGU'],
...
[960, 'Victor Rosales MX-ZAC'],
[961, 'Villa Gonzalez Ortega MX-ZAC'],
[962, 'Villanueva MX-ZAC'],
],Full list of cities: |
About this, there are some banks that disappeared or merged, that could be the cause for the disappearing banks. We may keep the old banks in the list for backward compatibility, what do you think? |
Yep, and for the bank codes that had different names, I searched to verify why. Sure enough, there was some kind of merger or takeover. Last week I updated the Next we should update the |
Hi!
I'm using this library, and some banks and cities are distinct from wikipedia, I'm getting the data from a development tools for a banking service.