Fix: on Google App Script, banks and cities with leading zero code were incorrectly parsed. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter (number base) for parseInt to be explicitly 10. Applied this
everywhere, although this was affecting banks: CLABES with a 0xx code (such as
BANORTE, "072") were being interpreted wrong, because the leading zero means
"this is an octal number" (so, parseInt("072") returns 58, not 72) to parseInt
in default mode on some versions of JS. This made a valid BANORTE clabe to be
interpreted as having a BANREGIO bank tag (funny coincidence). This was
probably affecting city codes with leading zeroes too.
|
Wow, bummer that Google App Script is so behind the times. C'est la vie! Release v1.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of Javascript (Google App Script) still neeed the second
parameter (number base) for parseInt to be explicitly 10. Applied this
everywhere, although this was affecting banks: CLABES with a 0xx code (such as
BANORTE, "072") were being interpreted wrong, because the leading zero means
"this is an octal number" (so, parseInt("072") returns 58, not 72) to parseInt
in default mode on some versions of JS. This made a valid BANORTE clabe to be
interpreted as having a BANREGIO bank tag (funny coincidence). This was
probably affecting city codes with leading zeroes too.