Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Commit

Permalink
Update the message names for Config RPC. (#93)
Browse files Browse the repository at this point in the history
* Update the message names for Config RPC.

* Update message order and name.

* Rename to UpdatedLibraryConfig.

* Update gen-go files.
  • Loading branch information
songy23 authored Sep 6, 2018
1 parent 3234379 commit 2333df4
Show file tree
Hide file tree
Showing 2 changed files with 87 additions and 85 deletions.
164 changes: 83 additions & 81 deletions gen-go/agent/trace/v1/trace_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions opencensus/proto/agent/trace/v1/trace_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ option go_package = "github.com/census-instrumentation/opencensus-proto/gen-go/a
service TraceService {
// After initialization, this RPC must be kept alive for the
// entire life of the application. The agent pushes configs
// down to applications via a stream of requests.
rpc Config(stream ConfigTraceServiceResponse) returns (stream ConfigTraceServiceRequest) {}
// down to applications via a stream.
rpc Config(stream CurrentLibraryConfig) returns (stream UpdatedLibraryConfig) {}

// Allows applications to send spans to the agent.
// For performance reasons, it is recommended to keep this RPC
// alive for the entire life of the application.
rpc Export(stream ExportTraceServiceRequest) returns (stream ExportTraceServiceResponse) {}
}

message ConfigTraceServiceRequest {
message CurrentLibraryConfig {
// Identifier data effectively is a structured metadata.
// This is required only in the first message on the stream.
opencensus.proto.agent.common.v1.Node node = 1;
Expand All @@ -50,7 +50,7 @@ message ConfigTraceServiceRequest {
opencensus.proto.trace.v1.TraceConfig config = 2;
}

message ConfigTraceServiceResponse {
message UpdatedLibraryConfig {
// Requested updated configuration.
opencensus.proto.trace.v1.TraceConfig config = 2;
}
Expand Down

0 comments on commit 2333df4

Please sign in to comment.