Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

da: update go-da; configure default gas price #317

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

tuxcanfly
Copy link
Collaborator

@tuxcanfly tuxcanfly commented Jan 10, 2024

Overview

This PR updates go-da to v0.1.0 which allows client to configure the gas price. Default gas price is used for now.

Works with celestia-da v0.12.6 allows configuring gas price with --da.grpc.gasprice.

See: rollkit/celestia-da#49

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@mergify mergify bot added the A-op-batcher label Jan 10, 2024
@tuxcanfly tuxcanfly marked this pull request as draft January 10, 2024 17:26
@tuxcanfly tuxcanfly marked this pull request as ready for review January 12, 2024 20:09
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

mergify bot commented Jan 12, 2024

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the S-conflict label Jan 12, 2024
@mergify mergify bot removed the S-conflict label Jan 12, 2024
@tuxcanfly tuxcanfly merged commit e4d22fe into celestia-develop Jan 12, 2024
5 checks passed
@tuxcanfly tuxcanfly deleted the tux/gas-price branch January 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants