-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace outdated dependency with security flags #305
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage 25.27% 25.27%
=======================================
Files 37 37
Lines 1187 1187
Branches 235 235
=======================================
Hits 300 300
Misses 859 859
Partials 28 28 ☔ View full report in Codecov by Sentry. |
hey @Nusnus, thanks for running the pipeline for this 🙏 . Let me know if you need anything here or is it good to go as is. |
Thanks for the PR! I’ll let you know if anything else is needed, thank you! |
Was noticing the same issue and found this PR. If for some reason funcy doesn't work there's also tenacity as an option, though I guess this mostly just needs to be updated again so that tests pass? |
I'm leaning towards tenacity as well. |
@shcheklein @jerr0328 @skshetry |
Released in v1.0.1 |
pytest-celery
raises security scan alert (e.g. https://github.com/iterative/dvc-task/actions/runs/8883067284/job/24389104408?pr=128)It depends on
retry
libm which itself depends (for no good reason) onpy
which is flagged for security and is outdated:invl/retry#58
invl/retry#60
It seems it's not maintained (last release / update is ~8 years ago).
A replacement is
funcy
- lightweight (no dependencies AFAIK), license is good, maintained. We have been using it in DVC.org for a while.