Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update process.py to close during join only if process has completed #390

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Update process.py to close during join only if process has completed #390

merged 1 commit into from
Jul 24, 2023

Conversation

benmosher
Copy link
Contributor

@benmosher benmosher commented Jul 20, 2023 •
edited
Loading

If a timeout is set, the wait will return before process exit. close deletes the sentinel and breaks future join calls.

These 4 spaces allow multiple joins with a a timeout, as multiprocessing does.

Should fix #270.

@benmosher
Update process.py to close during join only if process has completed
3672992 
If a timeout is set, the wait will return before process exit. `close` deletes the sentinel and breaks future `join` calls.
@auvipy auvipy merged commit 5030d32 into celery:main Jul 24, 2023
7 checks passed
@davidharting
Copy link

Thanks for merging this @auvipy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: argument must be an int, or have a fileno() method.
3 participants
@benmosher @davidharting @auvipy