forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'upstream/launchpad/backports' into v0.39
- Loading branch information
Showing
43 changed files
with
4,507 additions
and
2,755 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,5 @@ | ||
# CODEOWNERS: https://help.github.com/articles/about-codeowners/ | ||
|
||
# Primary repo maintainers | ||
* @rigelrozanski @alexanderbez @jackzampolin @alessio @fedekunze | ||
# Launchpad Stable Release Managers | ||
* @alessio @clevinson @ethanfrey | ||
|
||
############################################################################### | ||
# Module Specific Ownership | ||
# See CONTRIBUTING.md for further details | ||
############################################################################### | ||
|
||
# The following contributors own all files in the x/nft directory at the root | ||
# of the repository and any of its subdirectories. | ||
x/nft @okwme @fedekunze |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,26 +13,163 @@ jobs: | |
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | ||
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master'" | ||
|
||
test-coverage-upload: | ||
split-test-files: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/setup-go@v2-beta | ||
- uses: actions/checkout@v2 | ||
- uses: technote-space/get-diff-action@v1 | ||
- name: Create a file with all the pkgs | ||
run: go list ./... > pkgs.txt | ||
- name: Split pkgs into 4 files | ||
run: split -n l/4 --additional-suffix=.txt ./pkgs.txt | ||
# cache multiple | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-aa" | ||
path: ./xaa.txt | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ab" | ||
path: ./xab.txt | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ac" | ||
path: ./xac.txt | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ad" | ||
path: ./xad.txt | ||
|
||
test-coverage-run-1: | ||
runs-on: ubuntu-latest | ||
needs: split-test-files | ||
timeout-minutes: 15 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: technote-space/get-diff-action@v3 | ||
id: git_diff | ||
with: | ||
SUFFIX_FILTER: | | ||
.go | ||
.mod | ||
.sum | ||
- name: build | ||
- uses: actions/download-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-aa" | ||
if: "env.GIT_DIFF != ''" | ||
- name: test & coverage report creation | ||
run: | | ||
make build | ||
cat xaa.txt | xargs go test -mod=readonly -timeout 15m -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
if: "env.GIT_DIFF != ''" | ||
- name: filter out DONTCOVER | ||
run: | | ||
excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')" | ||
excludelist+=" $(find ./ -type f -name '*.pb.go')" | ||
excludelist+=" $(find ./ -type f -path './tests/mocks/*.go')" | ||
for filename in ${excludelist}; do | ||
filename=$(echo $filename | sed 's/^./github.com\/cosmos\/cosmos-sdk/g') | ||
echo "Excluding ${filename} from coverage report..." | ||
sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt | ||
done | ||
if: "env.GIT_DIFF != ''" | ||
- uses: codecov/[email protected] | ||
with: | ||
file: ./coverage.txt | ||
if: "env.GIT_DIFF != ''" | ||
|
||
test-coverage-run-2: | ||
runs-on: ubuntu-latest | ||
needs: split-test-files | ||
timeout-minutes: 15 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: technote-space/get-diff-action@v3 | ||
id: git_diff | ||
with: | ||
SUFFIX_FILTER: | | ||
.go | ||
.mod | ||
.sum | ||
- uses: actions/download-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ab" | ||
if: "env.GIT_DIFF != ''" | ||
- name: test & coverage report creation | ||
run: | | ||
cat xab.txt | xargs go test -mod=readonly -timeout 15m -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
if: "env.GIT_DIFF != ''" | ||
- name: filter out DONTCOVER | ||
run: | | ||
excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')" | ||
excludelist+=" $(find ./ -type f -name '*.pb.go')" | ||
excludelist+=" $(find ./ -type f -path './tests/mocks/*.go')" | ||
for filename in ${excludelist}; do | ||
filename=$(echo $filename | sed 's/^./github.com\/cosmos\/cosmos-sdk/g') | ||
echo "Excluding ${filename} from coverage report..." | ||
sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt | ||
done | ||
if: "env.GIT_DIFF != ''" | ||
- uses: codecov/[email protected] | ||
with: | ||
file: ./coverage.txt | ||
if: "env.GIT_DIFF != ''" | ||
|
||
test-coverage-run-3: | ||
runs-on: ubuntu-latest | ||
needs: split-test-files | ||
timeout-minutes: 15 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: technote-space/get-diff-action@v3 | ||
id: git_diff | ||
with: | ||
SUFFIX_FILTER: | | ||
.go | ||
.mod | ||
.sum | ||
- uses: actions/download-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ac" | ||
if: "env.GIT_DIFF != ''" | ||
- name: test & coverage report creation | ||
run: | | ||
cat xac.txt | xargs go test -mod=readonly -timeout 15m -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
if: "env.GIT_DIFF != ''" | ||
- name: filter out DONTCOVER | ||
run: | | ||
excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')" | ||
excludelist+=" $(find ./ -type f -name '*.pb.go')" | ||
excludelist+=" $(find ./ -type f -path './tests/mocks/*.go')" | ||
for filename in ${excludelist}; do | ||
filename=$(echo $filename | sed 's/^./github.com\/cosmos\/cosmos-sdk/g') | ||
echo "Excluding ${filename} from coverage report..." | ||
sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt | ||
done | ||
if: "env.GIT_DIFF != ''" | ||
- uses: codecov/[email protected] | ||
with: | ||
file: ./coverage.txt | ||
if: "env.GIT_DIFF != ''" | ||
|
||
test-coverage-run-4: | ||
runs-on: ubuntu-latest | ||
needs: split-test-files | ||
timeout-minutes: 15 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: technote-space/get-diff-action@v3 | ||
id: git_diff | ||
with: | ||
SUFFIX_FILTER: | | ||
.go | ||
.mod | ||
.sum | ||
- uses: actions/download-artifact@v2 | ||
with: | ||
name: "${{ github.sha }}-ad" | ||
if: "env.GIT_DIFF != ''" | ||
- name: test & coverage report creation | ||
run: | | ||
go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
cat xad.txt | xargs go test -mod=readonly -timeout 15m -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
if: "env.GIT_DIFF != ''" | ||
- name: filter out DONTCOVER | ||
run: | | ||
|
@@ -45,8 +182,7 @@ jobs: | |
sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt | ||
done | ||
if: "env.GIT_DIFF != ''" | ||
- uses: codecov/codecov-action@v1 | ||
- uses: codecov/codecov-action@v1.0.13 | ||
with: | ||
file: ./coverage.txt # optional | ||
fail_ci_if_error: true | ||
file: ./coverage.txt | ||
if: "env.GIT_DIFF != ''" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,47 @@ | ||
# Cosmos SDK v0.39.1 Release Notes | ||
# Cosmos SDK v0.39.2 Release Notes | ||
|
||
This release fixes the [issue affecting the accounts migration](https://github.com/cosmos/cosmos-sdk/issues/6828) from v0.38 to v0.39. | ||
This release fixes various bugs and brings coin's denom validation to the *Cosmos SDK 0.39* release series. | ||
|
||
See the [Cosmos SDK 0.39.1 milestone](https://github.com/cosmos/cosmos-sdk/milestone/29?closed=1) on our issue tracker for details. | ||
See the [Cosmos SDK 0.39.2 milestone](https://github.com/cosmos/cosmos-sdk/milestone/30?closed=1) on our issue tracker for details. | ||
|
||
## Remove custom JSON serialization for account types | ||
## Allow ValidateDenom() to be customised per application | ||
|
||
Account types JSON serialization has now changed to Amino. Changes are significant (e.g. integers are treated | ||
as strings) thus it is required to migrate the exported state of an application before restarting the node | ||
with a more recent version of the Cosmos SDK. | ||
Applications can now customise `types.Coin` denomination validation by passing | ||
their application-specific validation function to `types.SetCoinDenomRegex()`. | ||
|
||
## REST server's --unsafe-cors mode | ||
## Upgrade queries don't work after upgrade | ||
|
||
This a UX improvement [back ported from master](https://github.com/cosmos/cosmos-sdk/pull/6853) that allows developers to disable CORS | ||
restrictions during app development and testing by passing the `--unsafe-cors` option to the client's `rest-server` command. | ||
New stores can now be registered during an on-chain upgrade. This is to | ||
prevent blockchain state queries from stopping working after a successful upgrade. | ||
|
||
## Tendermint 0.33.7 | ||
## ApproxRoot() infinite looping | ||
|
||
Tendermint 0.33.7 brings an important regression fix. Please refer to [this bug report](https://github.com/tendermint/tendermint/issues/5112) for more information. | ||
The `types.Dec.ApproxRoot()` function has now a maximum number 100 iterations as backup boundary | ||
condition to prevent the client's code from entering an endless loop. | ||
|
||
## Go 1.15 | ||
|
||
This is the first release of the Launchpad series that has been tested and built with **go 1.15**. | ||
|
||
## Tendermint's updates | ||
|
||
Tendermint has received a few updates in the last development cycle. | ||
|
||
The pings frequency for remote private validators and the number of GetPubKey requests | ||
have been reduced to prevent validators from [failing to sync when using remote signers](https://github.com/tendermint/tendermint/issues/5550). | ||
|
||
A security vulnerability that affected the Go's `encoding/binary` package was reported. | ||
Tendermint's `v0.33.8` release was published with the objective to aid users in using the correct version of Go. | ||
Please refer to [this bug report](https://github.com/golang/go/issues/40618) for more information. | ||
|
||
## Known issues | ||
|
||
Keyrings using the `test` backend that were created with applications built with `Cosmos SDK v0.39.1` | ||
and `go 1.15` may break with the following error after re-compiling with `Cosmos SDK v0.39.2`: | ||
|
||
``` | ||
ERROR: aes.KeyUnwrap(): integrity check failed. | ||
``` | ||
|
||
This is due to [the update](https://github.com/99designs/keyring/pull/75) that the `jose2go` dependency | ||
has received that made it [fully compatible with go 1.15](https://github.com/dvsekhvalnov/jose2go/issues/26). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.