Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Use FQDNs as bad nodes hostnames #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fihuer
Copy link
Member

@fihuer fihuer commented Apr 19, 2021

In tests, use FQDNs for node that are expected to be (not) resolved as NXDOMAIN.

Without this, in environnements where local domain have wildcards DNS, anything (except FQDNs) can be resolved to something.

In tests, use FQDNs for node that are expected to be (not) resolved as NXDOMAIN.

Without this, in environnements where local domain have wildcards DNS, anything (except FQDNs) can be resolved to something.
@codecov-commenter
Copy link

Codecov Report

Merging #53 (e1f8875) into master (16d4ee0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   99.55%   99.53%   -0.03%     
==========================================
  Files          22       22              
  Lines        4984     4984              
==========================================
- Hits         4962     4961       -1     
- Misses         22       23       +1     
Impacted Files Coverage Δ
tests/MilkCheckTests/EngineTests/ActionTest.py 100.00% <100.00%> (ø)
...sts/MilkCheckTests/EngineTests/ServiceGroupTest.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/EngineTests/ServiceTest.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/UITests/CliTest.py 99.78% <100.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d4ee0...e1f8875. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants