Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken migration to test db-migration-failure-critical DO NOT MERGE #2421

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jan 21, 2025

Summary | Résumé

A broken migration (!)
This should set off the db-migration-failure-critical alarm in staging.

Will test by building the image locally and manually deploying to the staging k8s cluster

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

locally can run

flask db upgrade

to verify that the migration fails. You can then run

flask db current

to verify that the database hasn't changed, ie you're still on migration 0472

Release Instructions | Instructions pour le déploiement

Don't even think of it.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels changed the title broken migration to test db-migration-failure-critical DO NOT RELEASE broken migration to test db-migration-failure-critical DO NOT MERGE Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant