Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXmx: read data_scale_factor #756

Merged
merged 12 commits into from
Oct 30, 2024
Merged

NXmx: read data_scale_factor #756

merged 12 commits into from
Oct 30, 2024

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Sep 13, 2024

New parameter as of nexusformat/definitions#1343. This is not full support of the parameter or of data_offset, but it's one of the use cases needed, namely reading a single gain value

phyy-nx and others added 3 commits September 13, 2024 14:24
New parameter as of nexusformat/definitions#1343. This is not full support of the parameter or of data_offset, but it's one of the use cases needed, namely reading a single gain value
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Sep 13, 2024

Requires dials/nxmx#40

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Sep 19, 2024

Now includes a test using data from @biochem-fan (thanks!), derived from CXI.DB #221. This is SACLA MPCCD data reformatted as NeXus NXmx, adding data_scale_factor as a parameter to account for a gain of 10.

@ndevenish this will need a new build of dials-data and of nxmx for these tests to pass. Thanks!

@ndevenish
Copy link
Collaborator

Okay, this seems to be picking up the new nxmx now, errors of form:

>       detector = dxtbx.nexus.get_dxtbx_detector(instrument.detectors[0], wavelength)
E       TypeError: get_dxtbx_detector() missing 1 required positional argument: 'nxdata'

tests/nexus/test_build_dxtbx_models.py:275: TypeError

@ndevenish
Copy link
Collaborator

Otherwise, I think this is ready-to-go?

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Oct 30, 2024

Great, thanks!

@phyy-nx phyy-nx merged commit 834cb48 into main Oct 30, 2024
16 checks passed
@phyy-nx phyy-nx deleted the nxmx_gain branch October 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants