-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXmx: read data_scale_factor #756
Conversation
New parameter as of nexusformat/definitions#1343. This is not full support of the parameter or of data_offset, but it's one of the use cases needed, namely reading a single gain value
for more information, see https://pre-commit.ci
Requires dials/nxmx#40 |
Now includes a test using data from @biochem-fan (thanks!), derived from CXI.DB #221. This is SACLA MPCCD data reformatted as NeXus NXmx, adding data_scale_factor as a parameter to account for a gain of 10. @ndevenish this will need a new build of dials-data and of nxmx for these tests to pass. Thanks! |
Okay, this seems to be picking up the new nxmx now, errors of form:
|
Otherwise, I think this is ready-to-go? |
Great, thanks! |
New parameter as of nexusformat/definitions#1343. This is not full support of the parameter or of data_offset, but it's one of the use cases needed, namely reading a single gain value