Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatCBFMiniEigerChessID7B2 #649

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jul 26, 2023

The rotation axis at CHESS ID7B2 is antiparallel to the fast direction, as spotted during work on dials/dials#2464. This PR adds specific support for that beamline.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #649 (022b71d) into main (930be09) will decrease coverage by 0.28%.
Report is 10 commits behind head on main.
The diff coverage is 29.78%.

❗ Current head 022b71d differs from pull request most recent head ba40f4d. Consider uploading reports for the commit ba40f4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   39.40%   39.13%   -0.28%     
==========================================
  Files         178      180       +2     
  Lines       15542    15839     +297     
  Branches     3004     3062      +58     
==========================================
+ Hits         6125     6199      +74     
- Misses       8836     9056     +220     
- Partials      581      584       +3     

Copy link
Collaborator

@graeme-winter graeme-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggest @ndevenish do the news but otherwise gently suggest stripping some less than useful comments out, otherwise looks good thank you

newsfragments/649.feature Outdated Show resolved Hide resolved
src/dxtbx/format/FormatCBFMiniEigerChessID7B2.py Outdated Show resolved Hide resolved
src/dxtbx/format/FormatCBFMiniEigerChessID7B2.py Outdated Show resolved Hide resolved
src/dxtbx/format/FormatCBFMiniEigerChessID7B2.py Outdated Show resolved Hide resolved
@dagewa
Copy link
Member Author

dagewa commented Jul 28, 2023

Thanks @graeme-winter. The comments etc. came directly from FormatCBFMiniEigerMaxIVBio, which I copied as the start point. Should I also edit that format as part of this PR?

@graeme-winter
Copy link
Collaborator

Thanks @graeme-winter. The comments etc. came directly from FormatCBFMiniEigerMaxIVBio, which I copied as the start point. Should I also edit that format as part of this PR?

I would say no, because that is out of scope, I just thought avoiding extra useless commentary was worthwhile. Not hostile to taking a look through the wider repo at some point to do some lint removal.

@ndevenish ndevenish enabled auto-merge (squash) August 10, 2023 15:01
@ndevenish ndevenish merged commit 206c7cb into cctbx:main Aug 10, 2023
10 of 11 checks passed
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants