-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormatCBFMiniEigerChessID7B2
#649
Conversation
ID7B2, where the rotation axis is antiparallel to fast. Fixes dials/dials#2464
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 39.40% 39.13% -0.28%
==========================================
Files 178 180 +2
Lines 15542 15839 +297
Branches 3004 3062 +58
==========================================
+ Hits 6125 6199 +74
- Misses 8836 9056 +220
- Partials 581 584 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, suggest @ndevenish do the news but otherwise gently suggest stripping some less than useful comments out, otherwise looks good thank you
Thanks @graeme-winter. The comments etc. came directly from |
I would say no, because that is out of scope, I just thought avoiding extra useless commentary was worthwhile. Not hostile to taking a look through the wider repo at some point to do some lint removal. |
The rotation axis at CHESS ID7B2 is antiparallel to the
fast
direction, as spotted during work on dials/dials#2464. This PR adds specific support for that beamline.